Skip to content

refactor: deletions + changes for newer Core-CMS + Core-Styles#535

Draft
wesleyboar wants to merge 53 commits intomainfrom
feat/update-core-cms-and-core-styles
Draft

refactor: deletions + changes for newer Core-CMS + Core-Styles#535
wesleyboar wants to merge 53 commits intomainfrom
feat/update-core-cms-and-core-styles

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Feb 5, 2026

Overview

Updates:

Deletes:

  • code that is migrated to Core-CMS
  • code that is migrated to Core-Styles

Refactors:

  • outdated method to install Blog/News

Caution

Untested.

Note

After deploy:

Related

Changes

  • updates html_page_id from portal to page-portal
  • updates assets_core_project to assets_project
  • deletes styling for icons migrated to Core-CMS
  • deletes scripting for external post links migrated to Core-CMS
  • deletes styling for c-feed-list migrated to Core-CMS (Core-Styles@v2.44.0, Core-CMS@v4.33)
  • moves styling for header to new appropriate stylesheet
  • moves scripting for HotJar analytics to ad-hoc scripts
  • deletes scripting for new window accessibility since managed by Core-CMS (#844, #1089)
  • moves tup-cms.for-*.css from template to PORTAL_STYLES
  • deletes scripting for breadcrumbs migrated to Core-CMS
  • deletes plain.html template migrated to Core-CMS
  • refactors how to enable and configure Blog/News
  • updates settings_custom.py details
  • moves styling for footer to new appropriate stylesheet
  • updates styling for footer (mirrors fix: a11y issues #537)
  • updated to newer Core-CMS
  • adds node = "18" to mise.toml and fixes CI error
  • updates to newer Core-Styles

Testing & UI

Core-CMS

  1. header, style and layout unchanged
  2. page News, feed's external articles all still open different website
    verify at least two external articles per page
  3. plugin Form, forms can be submitted e.g.
    • /about/tours/request/
  4. assets, custom stylesheets are loaded:
    • tup-cms.for-core-cms.css
    • tup-cms.for-core-style.css
    • tup-cms.for-tup-cms.css
  5. page Search, search results are styled
  6. page Training & Events, has same feed styles
  7. page User Updates, has same feed styles
    • especially, verify each update has no byline
  8. script HotJar, tracking is still active
  9. pages that are deeply nested, still disable 2nd breadcrumb e.g.
    • /news/latest-news/
    • /systems/all/
  10. plugin Icon, editor form has same style and still works
  11. plugin Link/Button, renders buttons with Core-Styles UI
  12. page News article (any):
    to test on prod, remove/comment snippet #172
  13. footer, social media icons unchanged
    to test on prod, remove/comment snippet #172
  14. footer, social media icons change color (white to light gray) on hover
  15. page News, style and layout are unchanged.
  16. page News article (any), style and layout are unchanged.
  17. page News article (any), publish time options are changed.
  18. plugins, new ones available:
    • "Latest Blog Articles"
    • "Featured Posts"
  19. page News article (any), updated editor form options:
  20. page News tagged frontera, should not show Frontera in HTML of title
    see screenshot of Lccf (before it was renamed to LCCF)
  21. portal, "Cortal" icons still load e.g. sidebar icons
  22. misc pages, an <h2> is brown and an <h3> is white or black
  23. plugin "Link / Button":
    • not "⚠️ " in title
    • not "⚠️ This plugin is deprecated." message in form
    • has "Type:" and "Size:" with Core-Styles options
    • not "Context:" nor "Size:" previews
    • not "Outline" nor "Block" checkboxes
    • has "Icon left" and "Icon right" icon selection dropdowns
    • renders correctly based on options chosen
      (see demo videos)

Core-Styles

  1. page News, style and layout are unchanged.
  2. page News article (any), style and layout are unchanged.

Otherwise, nothing to test, because the rest is fixes or opt-in features.

TACC/Core-CMS#1033 automates redirect logic.

#529 was stepping stone.

But this PR does not need those steps nor old code.
The ad-hoc.js definitely works.

I use it on TACC site live, and other Core-CMS sites.
This has been working via Core-CMS for almost a year.

TACC/Core-CMS#838
This file is nto the same code as Core-CMS. No need for it.

By deleting this one, it will nto be copied.

The default one in Core-CMS image will be used.
So that CMS nav width does not increase with CMS font.
Core-Styles flipped font to Benton (CMS) then back to Roboto (Portal).
This reverts commit 90be726.

Core-CMS brings hover states (color of SVG changes to brand color of that social media).
No reason to override this.

If CMS admin wants to use `<small>`, let her. I just tweak font-size.
Core-Styles was updated to also use `--max-width: auto`.

Thus, TUP CMS need not set it.
Core-CMS offers —

```css
[class*="logos--"] a svg {
  display: block;
}
```

— which makes `vertical-align: middle`[^1] have no effect.

[^1]: Even Bootstrap's `vertical-align: middle` has no effect.
Core-Styles fixed logo vertical alignment.
@wesleyboar wesleyboar mentioned this pull request Mar 9, 2026
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Mar 17, 2026
## Overview

Greater default size for branding logos (from snippet).

## Related

- supports TACC/tup-ui#535
- supports TACC/tup-ui#537

## Changes

- **added** bix width and height constraints into SVG CSS
- **deleted** tiny width and height constraints from SVG HTML

## Testing

Dimensions of branding logos (from snippet) are constrained by their
parent container or their max block size (500px).

## UI

| before | after | test max size |
| - | - | - |
| <img width="900" height="470" alt="before"
src="https://github.com/user-attachments/assets/a4007928-612e-468c-af2f-7bf1f2b7c628"
/> | <img width="900" height="470" alt="after"
src="https://github.com/user-attachments/assets/5a9400e7-5e43-4fc3-a6f2-8055d3dcbba2"
/> | <img width="900" height="470" alt="test max size"
src="https://github.com/user-attachments/assets/22394a28-c220-4d77-a1c8-621b4f46c1db"
/> |
@wesleyboar wesleyboar changed the title deps: update Core-CMS & Core-Styles refactor: deletions + changes for newer Core-CMS + Core-Styles Mar 18, 2026
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Mar 18, 2026
## Overview

Add TACC styles for [Bootstrap 5 `link`
Utility](https://getbootstrap.com/docs/5.3/utilities/link/).

## Related

- for [TACC: About > LCCF Internships
](https://tacc.utexas.edu/about/internships/lccf/)
- for [ECEP: CS Data > ECEP CS
Education](https://ecepalliance.org/cs-data/ecep-cs-education-dashboard/)
- tested via TACC/tup-ui#535

## Changes

- **adds**
[TACC/Core-Styles:core-styles.bootstrap5.css](https://github.com/TACC/Core-Styles/blob/v2.53.3/src/lib/_imports/core-styles.bootstrap5.css)

## Testing

1. Verify `.link-primary` styles any element link a link e.g.
    - `<button class="link-primary">`
    - `<summary class="link-primary">`

## UI


https://github.com/user-attachments/assets/353c2b7c-9311-432e-bf5c-5e8360001810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant