refactor: deletions + changes for newer Core-CMS + Core-Styles#535
Draft
wesleyboar wants to merge 53 commits intomainfrom
Draft
refactor: deletions + changes for newer Core-CMS + Core-Styles#535wesleyboar wants to merge 53 commits intomainfrom
wesleyboar wants to merge 53 commits intomainfrom
Conversation
TACC/Core-CMS#1033 automates redirect logic. #529 was stepping stone. But this PR does not need those steps nor old code.
The ad-hoc.js definitely works. I use it on TACC site live, and other Core-CMS sites.
This has been working via Core-CMS for almost a year. TACC/Core-CMS#838
This file is nto the same code as Core-CMS. No need for it. By deleting this one, it will nto be copied. The default one in Core-CMS image will be used.
Available since TACC/Core-CMS#611. Updated in TACC/Core-CMS#996.
Update TUP-CMS styles to respect new Core-CMS styles: See TACC/Core-CMS#1028 Then TACC/Core-CMS#1029 Delete https://tacc.utexas.edu/admin/djangocms_snippet/snippet/172/
So that CMS nav width does not increase with CMS font.
Core-Styles flipped font to Benton (CMS) then back to Roboto (Portal).
This reverts commit 90be726. Core-CMS brings hover states (color of SVG changes to brand color of that social media).
No reason to override this. If CMS admin wants to use `<small>`, let her. I just tweak font-size.
Core-Styles was updated to also use `--max-width: auto`. Thus, TUP CMS need not set it.
Core-CMS offers —
```css
[class*="logos--"] a svg {
display: block;
}
```
— which makes `vertical-align: middle`[^1] have no effect.
[^1]: Even Bootstrap's `vertical-align: middle` has no effect.
Core-Styles fixed logo vertical alignment.
This is the new way to do it. TUP CMS is the only client using old way.
These settings were moved in TACC/Core-CMS#v4.35.10
https://github.com/search?q=repo%3ATACC%2Ftup-ui%20%22%23page-portal%22&type=code The `page-` was forced in TACC/Core-CMS#v4.28 but not since TACC/Core-CMS#v4.29 https://github.com/TACC/Core-CMS/blob/v4.28.0/taccsite_cms/templates/base.html#L5 https://github.com/TACC/Core-CMS/blob/v4.29.0/taccsite_cms/templates/base.html
This reverts commit 210bd0c.
This reverts commit fcff12f.
Has not been used for a while in favor of Core-CMS. Outdated since TACC/Core-CMS@89355dd6, in which COre-CMS brings over improvements this script had.
- v4.38.4 has important fixes - v4.38.5 has non-breaking features
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Mar 17, 2026
## Overview Greater default size for branding logos (from snippet). ## Related - supports TACC/tup-ui#535 - supports TACC/tup-ui#537 ## Changes - **added** bix width and height constraints into SVG CSS - **deleted** tiny width and height constraints from SVG HTML ## Testing Dimensions of branding logos (from snippet) are constrained by their parent container or their max block size (500px). ## UI | before | after | test max size | | - | - | - | | <img width="900" height="470" alt="before" src="https://github.com/user-attachments/assets/a4007928-612e-468c-af2f-7bf1f2b7c628" /> | <img width="900" height="470" alt="after" src="https://github.com/user-attachments/assets/5a9400e7-5e43-4fc3-a6f2-8055d3dcbba2" /> | <img width="900" height="470" alt="test max size" src="https://github.com/user-attachments/assets/22394a28-c220-4d77-a1c8-621b4f46c1db" /> |
To fix tiny branding logos in footer.
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Mar 18, 2026
## Overview Add TACC styles for [Bootstrap 5 `link` Utility](https://getbootstrap.com/docs/5.3/utilities/link/). ## Related - for [TACC: About > LCCF Internships ](https://tacc.utexas.edu/about/internships/lccf/) - for [ECEP: CS Data > ECEP CS Education](https://ecepalliance.org/cs-data/ecep-cs-education-dashboard/) - tested via TACC/tup-ui#535 ## Changes - **adds** [TACC/Core-Styles:core-styles.bootstrap5.css](https://github.com/TACC/Core-Styles/blob/v2.53.3/src/lib/_imports/core-styles.bootstrap5.css) ## Testing 1. Verify `.link-primary` styles any element link a link e.g. - `<button class="link-primary">` - `<summary class="link-primary">` ## UI https://github.com/user-attachments/assets/353c2b7c-9311-432e-bf5c-5e8360001810
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates:
Deletes:
Refactors:
Caution
Untested.
Note
After deploy:
Related
Changes
html_page_idfromportaltopage-portalassets_core_projecttoassets_projectc-feed-listmigrated to Core-CMS (Core-Styles@v2.44.0, Core-CMS@v4.33)tup-cms.for-*.cssfrom template toPORTAL_STYLESplain.htmltemplate migrated to Core-CMSsettings_custom.pydetailsnode = "18"tomise.tomland fixes CI errorTesting & UI
Core-CMS
verify at least two external articles per page
/about/tours/request/tup-cms.for-core-cms.csstup-cms.for-core-style.csstup-cms.for-tup-cms.css/news/latest-news//systems/all/to test on prod, remove/comment snippet #172
to test on prod, remove/comment snippet #172
frontera, should not showFronterain HTML of titlesee screenshot of
Lccf(before it was renamed toLCCF)<h2>is brown and an<h3>is white or black(see demo videos)
Core-Styles
Otherwise, nothing to test, because the rest is fixes or opt-in features.