Skip to content

Add flute magic files in /etc to install#3

Merged
tspyrou merged 2 commits into
developfrom
add_etc_to_install
Nov 27, 2019
Merged

Add flute magic files in /etc to install#3
tspyrou merged 2 commits into
developfrom
add_etc_to_install

Conversation

@tspyrou
Copy link
Copy Markdown
Contributor

@tspyrou tspyrou commented Nov 20, 2019

No description provided.

Tom Spyrou added 2 commits November 20, 2019 06:48
…te magic files. Its expected these will go away soon but installing the /etc directory is typically done.
@tspyrou tspyrou requested a review from jjcherry56 November 20, 2019 15:37
@tspyrou tspyrou self-assigned this Nov 27, 2019
@tspyrou tspyrou removed the request for review from jjcherry56 November 27, 2019 15:57
@tspyrou tspyrou merged commit 0e3c5f8 into develop Nov 27, 2019
@tspyrou tspyrou deleted the add_etc_to_install branch November 27, 2019 15:58
tspyrou pushed a commit that referenced this pull request Sep 10, 2020
antonblanchard added a commit to antonblanchard/OpenROAD that referenced this pull request Jan 10, 2021
LLVM address sanitizer hits an array out of bounds access:

    #0 in fr::FlexGridGraph::getEdgeLength(int, int, int, fr::frDirEnum) const src/TritonRoute/src/dr/FlexGridGraph.h
    The-OpenROAD-Project#1 in fr::FlexDRWorker::initMazeCost_ap_planarGrid_helper(fr::FlexMazeIdx const&, fr::frDirEnum const&, int, bool) src/TritonRoute/src/dr/FlexDR_init.cpp
    The-OpenROAD-Project#2 in fr::FlexDRWorker::initMazeCost_ap_helper(fr::drNet*, bool) src/TritonRoute/src/dr/FlexDR_init.cpp:2314:11
    The-OpenROAD-Project#3 in fr::FlexDRWorker::mazeNetInit(fr::drNet*) src/TritonRoute/src/dr/FlexDR_maze.cpp:1767:3

There is already a call to isValid() to check the array indexes are
valid, but it is commented out. Add it back in.
openroad-robot referenced this pull request in The-OpenROAD-Project-staging/OpenROAD Oct 10, 2023
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
gudeh pushed a commit to gudeh/OpenROAD that referenced this pull request Sep 29, 2025
cclin0817 referenced this pull request in cclin0817/OpenROAD Nov 20, 2025
Documented 3 bugs and 1 limitation found in the py3dblox parser:
- Bug #1: None/null values converted to string "None"
- Bug #2: Wildcard paths only work in filename
- Bug #3: Missing validation for required non-null values
- Limitation: cad_layer field not implemented

The most critical issue is Bug #1 which causes data corruption.
RamboJHB pushed a commit to RamboJHB/OpenROAD that referenced this pull request May 8, 2026
Number every PG-DRC code change in the order data flows from the
user-facing Tcl flag down to the FlexGC checks, so a reader can grep
for [PG-DRC #1] .. [PG-DRC The-OpenROAD-Project#11] and walk the chain end to end:

  #1  TritonRoute.tcl          -- parse -check_pg_nets
  The-OpenROAD-Project#2  TritonRoute.i            -- SWIG bridge
  The-OpenROAD-Project#3  TritonRoute.h            -- public API param
  The-OpenROAD-Project#4  TritonRoute.cpp          -- write router_cfg_->CHECK_PG_NETS
  The-OpenROAD-Project#5  global.h                 -- RouterConfiguration field
  The-OpenROAD-Project#6  serialization.h          -- distributed-worker serialization
  The-OpenROAD-Project#7  frRegionQuery.cpp        -- feed PG snets to drObjs rtree
  The-OpenROAD-Project#8  FlexGC_init.cpp          -- skip PG in fixed-obstacle pass
  The-OpenROAD-Project#9  FlexGC_cut.cpp           -- gate via-table supply-skip
  The-OpenROAD-Project#10 drc_test_pg.tcl          -- end-to-end smoke regression
  The-OpenROAD-Project#11 CMakeLists.txt / BUILD   -- register test in both build systems

Also document why FlexGCWorker::Impl::checkCutSpacing_spc() is
deliberately left alone: that skip honors LEF SAMENETPGONLY and must
keep exempting same-PG-net cuts even when PG DRC is on.

Signed-off-by: Claude <noreply@anthropic.com>
RamboJHB pushed a commit to RamboJHB/OpenROAD that referenced this pull request May 8, 2026
…cfg field

Previous version stashed CHECK_PG_NETS in RouterConfiguration so every
downstream stage could read it via router_cfg_. That made the flag a
hidden global: it lived for the lifetime of the router, would persist
across calls, and forced a serialization entry for distributed
workers. Refactor to plumb the bool as an explicit parameter end to
end so PG checking happens only when, and exactly where, the user
asks for it.

  - Drop RouterConfiguration::CHECK_PG_NETS and its serialize line.
  - frRegionQuery::initDRObj gains an include_pg_nets bool (default
    false). All routing/repair callers keep the default; only
    TritonRoute::checkDRC passes true when -check_pg_nets is set.
  - FlexGCWorker gets setCheckPgNets(bool) + Impl::checkPgNets_;
    FlexGC_init.cpp / FlexGC_cut.cpp read the worker member instead
    of router_cfg_.
  - TritonRoute::getDRCMarkers takes the bool and forwards it to
    each FlexGCWorker before init.
  - TritonRoute::checkDRC body re-runs initDRObj(true) only when the
    flag is on (idempotent rebuild) and forwards the bool to
    getDRCMarkers; default check_drc and the routing flow are
    bit-identical to before.

Renumber [PG-DRC #N] markers to follow the new linear chain (#1..The-OpenROAD-Project#10):
  #1  Tcl flag parse
  The-OpenROAD-Project#2  SWIG bridge
  The-OpenROAD-Project#3  TritonRoute::checkDRC declaration
  The-OpenROAD-Project#4  TritonRoute::checkDRC body -> initDRObj(true)
  The-OpenROAD-Project#5  frRegionQuery::Impl::initDRObj feeds PG to drObjs
  The-OpenROAD-Project#6  TritonRoute::getDRCMarkers + FlexGCWorker::setCheckPgNets / member
  The-OpenROAD-Project#7  FlexGCWorker::Impl::initDesign obstacle-pass skip
  The-OpenROAD-Project#8  FlexGCWorker::Impl::checkMetalWidthViaTable supply-skip gate
  The-OpenROAD-Project#9  drc_test_pg.tcl smoke regression
  The-OpenROAD-Project#10 CMakeLists.txt / BUILD registration

Signed-off-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant