feat(gui): Implement money per minute display for local player

[L3-M]

This change implements player money per minute in Generals and Zero Hour.
Tracks income over the last 60 seconds. By default, it is disabled by "no" and can be enabled by the value "yes" in Options.ini.
By being disabled, it will fall back to the original current money only.

ShowMoneyPerMinute = yes

For example:

Note: Money per minute will not track income from canceling constructing buildings, canceling unit or upgrade production, or from surrendered player transfers, as these are not really "earned" by the player.

TODO

• Replicate in Generals

[Stubbjax]

What pain points does this feature solve? Is it not something skilled players can already intuit? Are the benefits worth the added complexity / cost to readability?

[ang1990]

Only game I know of that inlines the resource per min data point similar to this is Supreme Commander. But that game is a supply chain simulator compared to ZH.

Starcraft 2 has an income tab in replay mode only, so you can't see it while you're playing. income/min is useful if you're studying your replays and helps spectators understand the economy game, but I reckon not so much for the player himself.

[Mauller]

What pain points does this feature solve? Is it not something skilled players can already intuit? Are the benefits worth the added complexity / cost to readability?

A lot of people who watch Legis stream are often interested in his money, income, KD overlay and ask how to get it ingame.

[helmutbuhler]

I think this is a nice addition. I'd append the unit "/min" though to make it clearer what it means.

[L3-M]

I think this is a nice addition. I'd append the unit "/min" though to make it clearer what it means.

I don't think this is possible while remaining ControlBarPro addon compatibility as It has much less space in the money texture compared to the original game's ControlBar

[helmutbuhler]

I think this is a nice addition. I'd append the unit "/min" though to make it clearer what it means.

I don't think this is possible while remaining ControlBarPro addon compatibility as It has much less space in the money texture compared to the original game's ControlBar

Even if it overflows, it's fine. Someone will make an updated ControlBarPro addon soon that fixes the texture. And until then, you can still disable it.

[Faithfinder]

I'd leave the money display alone, and put this data into top-left corner together with other GenTool things. I'd be interested in seeing this data, but putting it next to current money might hinder comprehension speed

[xezon]

Perhaps it would be better suited for an Observer specific display.

[Eikosa]

Perhaps it would be better suited for an Observer specific display.

Frankly, it would be great fun to see this while playing singleplayer

[L3-M]

I'd leave the money display alone, and put this data into top-left corner together with other GenTool things. I'd be interested in seeing this data, but putting it next to current money might hinder comprehension speed

The money display is left alone. This feature is disabled by default now. I think it makes more sense this way.
Also I would not find myself looking at the top-left/right corner to see my current Money Per Minute, it looks better on the ControlBar GUI.

[L3-M]

Rebased onto main and addressed all comments

[xezon]

Code looks pretty solid. Just a few more questions left to tackle.

[L3-M]

Updated.

[L3-M]

Updated and rebased on main.

[xezon]

Needs to be replicated to Generals

[Simon-code87]

1. Would it be possible to update the cash‑per‑minute display only every five seconds? Otherwise, the numbers keep jumping around with every cash change.
2. Could cash‑per‑minute also be shown for supplies — for example, when the player clicks or hovers the mouse over them? That way, the player could better evaluate how well and efficiently their supply depots are positioned.

[L3-M]

1. Would it be possible to update the cash‑per‑minute display only every five seconds? Otherwise, the numbers keep jumping around with every cash change.

Yeah I can make a follow up change to make the money per minute update interval configurable, while keeping the current behavior as the default.

2. Could cash‑per‑minute also be shown for supplies — for example, when the player clicks or hovers the mouse over them? That way, the player could better evaluate how well and efficiently their supply depots are positioned.

That is outside the scope of this change.

[hussam-qaissy]

@L3-M , can you please let me know which control bar you are using, im using genpatcher and both exile and xezons control bars arent displaying the income per min correctly, the box width is small and the text is wrapped so not readable.

the original control bar wirks perfectly though, but i dont use it

[L3-M]

@L3-M , can you please let me know which control bar you are using, im using genpatcher and both exile and xezons control bars arent displaying the income per min correctly, the box width is small and the text is wrapped so not readable.

the original control bar wirks perfectly though, but i dont use it

I am using a custom version. You can check my fork for the changes required to adjust the money texture size:

L3-M/GeneralsControlBar@4646736

I have also published a release for anyone who wants to use this change with the money feature:

https://github.com/L3-M/GeneralsControlBar/releases

[Aliihuss99]

so does this add cash per minute in game or just in the replays ??

[hussam-qaissy]

@L3-M, has this feature been removed?

its no longer working for me, i also tried Gamedata.ini mentioned by @xezon but game crashes as soon as i start the game.

i hope you can do me favour on how to re-enable. Thanks.