Skip to content

tweak(gui): Add configuration to GameData.ini to allow Money Per Minute for players#1914

Merged
xezon merged 1 commit into
TheSuperHackers:mainfrom
L3-M:L3-M/money-gamedata
Nov 27, 2025
Merged

tweak(gui): Add configuration to GameData.ini to allow Money Per Minute for players#1914
xezon merged 1 commit into
TheSuperHackers:mainfrom
L3-M:L3-M/money-gamedata

Conversation

@L3-M

@L3-M L3-M commented Nov 26, 2025

Copy link
Copy Markdown

This change implements a GameData.ini option to enable or disable Money Per Minute for Players in Generals and Zero Hour.

The new option is AllowMoneyPerMinuteForPlayer, which is disabled by default and can be set to yes/no in GameData.ini when PRESERVE_RETAIL_BEHAVIOR is set to (0).

@L3-M L3-M self-assigned this Nov 26, 2025
@L3-M L3-M added Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Nov 26, 2025
Comment thread Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp Outdated
@L3-M L3-M force-pushed the L3-M/money-gamedata branch from 6486d37 to d060937 Compare November 26, 2025 16:18
@Mauller

Mauller commented Nov 26, 2025

Copy link
Copy Markdown

is the new variable really necessary when you already have m_showMoneyPerMinute?

@xezon

xezon commented Nov 26, 2025

Copy link
Copy Markdown

is the new variable really necessary when you already have m_showMoneyPerMinute?

I think it is, because m_showMoneyPerMinute is a user setting and the other is mod setting.

Comment thread Generals/Code/GameEngine/Source/Common/GlobalData.cpp Outdated
Comment thread Generals/Code/GameEngine/Source/Common/GlobalData.cpp Outdated
Comment thread Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp
@L3-M L3-M force-pushed the L3-M/money-gamedata branch from d060937 to 3161971 Compare November 27, 2025 16:42

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@xezon xezon changed the title tweak(gui): Configure player money per minute in GameData tweak(gui): Add configuration to GameData.ini to allow Money Per Minute for players Nov 27, 2025
@xezon xezon added Enhancement Is new feature or request ThisProject The issue was introduced by this project, or this task is specific to this project NoRetail This fix or change is not applicable with Retail game compatibility labels Nov 27, 2025
@xezon xezon merged commit b2afcd3 into TheSuperHackers:main Nov 27, 2025
27 checks passed
@L3-M L3-M deleted the L3-M/money-gamedata branch December 13, 2025 13:25
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Feb 23, 2026
…te for players (TheSuperHackers#1914)

The Money Per Minute display for Players can now be allowed or disallowed by setting AllowMoneyPerMinuteForPlayer=yes/no in GameData.ini. It is disabled by default and always disabled with PRESERVE_RETAIL_BEHAVIOR (1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Is new feature or request Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker NoRetail This fix or change is not applicable with Retail game compatibility ThisProject The issue was introduced by this project, or this task is specific to this project ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants