bugfix(anim): Fix elapsed time of object animations#1656
Merged
xezon merged 3 commits intoOct 22, 2025
Conversation
Author
|
Generals will fail to compile until replicated. |
|
Is it planned or expected that animations like the scaffold crane are properly scaled when fast-forwarding replays? UNSCALED_CRANES.mp4 |
Author
|
For sure. I have not yet made a pass on Fast Forwarding Time Scale. The feature needs to be reimplemented. The current implementation still uses the EA hacks. |
xezon
force-pushed
the
xezon/rendering-7-animation-update
branch
from
October 14, 2025 17:33
d1de77b to
d16b54a
Compare
Author
|
Updated. |
xezon
force-pushed
the
xezon/rendering-7-animation-update
branch
from
October 16, 2025 18:04
d16b54a to
bb1e2d7
Compare
Author
|
Rebased. |
4 tasks
xezon
force-pushed
the
xezon/rendering-7-animation-update
branch
from
October 18, 2025 12:15
bb1e2d7 to
d3292f8
Compare
|
Tested, works as intended. |
4 tasks
4 tasks
Stubbjax
reviewed
Oct 20, 2025
xezon
force-pushed
the
xezon/rendering-7-animation-update
branch
from
October 20, 2025 16:49
d3292f8 to
94cbf53
Compare
Author
|
Rebased. |
Stubbjax
approved these changes
Oct 20, 2025
xezon
force-pushed
the
xezon/rendering-7-animation-update
branch
from
October 22, 2025 16:49
94cbf53 to
f465317
Compare
Author
|
Replicated in Generals without conflicts. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a follow up for #1579 and fixes the elapsed time of object animations. It also adds the elapsed time for seg line again.
The deal with these updates is that they are not guaranteed to update always, but are only updated when inside world view. That is why we need to keep track of the absolute time of the last update instead of accumulating the frame time every render update.
TODO