Skip to content

bugfix(anim): Fix elapsed time of object animations#1656

Merged
xezon merged 3 commits into
TheSuperHackers:mainfrom
xezon:xezon/rendering-7-animation-update
Oct 22, 2025
Merged

bugfix(anim): Fix elapsed time of object animations#1656
xezon merged 3 commits into
TheSuperHackers:mainfrom
xezon:xezon/rendering-7-animation-update

Conversation

@xezon

@xezon xezon commented Sep 29, 2025

Copy link
Copy Markdown

This change is a follow up for #1579 and fixes the elapsed time of object animations. It also adds the elapsed time for seg line again.

The deal with these updates is that they are not guaranteed to update always, but are only updated when inside world view. That is why we need to keep track of the absolute time of the last update instead of accumulating the frame time every render update.

TODO

  • Replicate in Generals

@xezon xezon added Bug Something is not working right, typically is user facing Minor Severity: Minor < Major < Critical < Blocker ThisProject The issue was introduced by this project, or this task is specific to this project Rendering Is Rendering related labels Sep 29, 2025
@xezon xezon added this to the Decouple logic and rendering milestone Sep 29, 2025
@xezon

xezon commented Sep 29, 2025

Copy link
Copy Markdown
Author

Generals will fail to compile until replicated.

@Stubbjax

Stubbjax commented Oct 1, 2025

Copy link
Copy Markdown

Is it planned or expected that animations like the scaffold crane are properly scaled when fast-forwarding replays?

UNSCALED_CRANES.mp4

@xezon

xezon commented Oct 1, 2025

Copy link
Copy Markdown
Author

For sure. I have not yet made a pass on Fast Forwarding Time Scale. The feature needs to be reimplemented. The current implementation still uses the EA hacks.

@xezon
xezon force-pushed the xezon/rendering-7-animation-update branch from d1de77b to d16b54a Compare October 14, 2025 17:33
@xezon

xezon commented Oct 14, 2025

Copy link
Copy Markdown
Author

Updated.

@xezon
xezon force-pushed the xezon/rendering-7-animation-update branch from d16b54a to bb1e2d7 Compare October 16, 2025 18:04
@xezon

xezon commented Oct 16, 2025

Copy link
Copy Markdown
Author

Rebased.

@xezon
xezon force-pushed the xezon/rendering-7-animation-update branch from bb1e2d7 to d3292f8 Compare October 18, 2025 12:15
@ElTioRata

Copy link
Copy Markdown

Tested, works as intended.

Comment thread GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/animobj.cpp Outdated
@xezon
xezon force-pushed the xezon/rendering-7-animation-update branch from d3292f8 to 94cbf53 Compare October 20, 2025 16:49
@xezon

xezon commented Oct 20, 2025

Copy link
Copy Markdown
Author

Rebased.

@xezon xezon added Major Severity: Minor < Major < Critical < Blocker and removed Minor Severity: Minor < Major < Critical < Blocker labels Oct 20, 2025
@xezon xezon added the Approved Pull Request was approved label Oct 21, 2025
@xezon
xezon force-pushed the xezon/rendering-7-animation-update branch from 94cbf53 to f465317 Compare October 22, 2025 16:49
@xezon

xezon commented Oct 22, 2025

Copy link
Copy Markdown
Author

Replicated in Generals without conflicts.

@xezon
xezon merged commit d83c8c9 into TheSuperHackers:main Oct 22, 2025
18 checks passed
@xezon
xezon deleted the xezon/rendering-7-animation-update branch October 22, 2025 20:00
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Pull Request was approved Bug Something is not working right, typically is user facing Major Severity: Minor < Major < Critical < Blocker Rendering Is Rendering related ThisProject The issue was introduced by this project, or this task is specific to this project

Projects

None yet

3 participants