sync: port upstream docs fixes and legal docs (#3990–#3992, #3972, #4000)#155
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
github-actions
Bot
added
the
vouch:trusted
github-actions
Bot
added
the
size:XXL
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe marketing site adds legal document pages and navigation. The mobile app adds a Legal settings route with validated WebView access. Documentation updates reflect current workflows and repository links, while Expo development networking switches to LAN mode. ChangesMarketing legal documents
Mobile legal document access
Mobile development workflow
Documentation updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Settings
participant LegalRoute
participant WebView
participant Browser
Settings->>LegalRoute: open Legal
LegalRoute->>WebView: load validated document URL
WebView->>LegalRoute: report loading or navigation state
LegalRoute->>Browser: open non-legal URL externally
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aaditagrawal
changed the title
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/marketing/src/layouts/Layout.astro`:
- Around line 432-434: Update the mobile `.legal-document-page .nav` styling in
`Layout.astro` so the Legal index retains a navigable Home link: remove the
global hide, scope it only to individual legal document pages using their
distinguishing class, or add an equivalent prominent Home link for the index and
preserve existing document-page navigation.
In `@docs/architecture/overview.md`:
- Around line 94-95: Update the architecture overview’s browser API reference
from the undefined nativeApi shorthand to wsNativeApi, matching the startup flow
and supplied source context. Keep the surrounding WsTransport and wsServer
descriptions unchanged.
In `@docs/operations/ci.md`:
- Line 3: Update the CI description in docs/operations/ci.md to list vp check
and vpr typecheck as separate commands, removing the inaccurate “lint +
typecheck” parenthetical while preserving the existing pull request, main push,
and test command details.
In `@docs/operations/effect-fn-checklist.md`:
- Around line 196-198: Remove the empty unlabeled code fence in the
documentation section around the referenced checklist content, or add an
appropriate language tag only if the code block is intentional. Ensure the
Markdown remains formatter-clean and run vp check --fix before committing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0c1d24b1-57be-43ad-ad8b-99690ff4d942
📒 Files selected for processing (18)
apps/marketing/src/components/LegalPage.astroapps/marketing/src/layouts/Layout.astroapps/marketing/src/pages/legal.astroapps/marketing/src/pages/privacy-policy.astroapps/marketing/src/pages/security-policy.astroapps/marketing/src/pages/terms-of-service.astroapps/mobile/package.jsonapps/mobile/src/Stack.tsxapps/mobile/src/features/settings/SettingsLegalRouteScreen.tsxapps/mobile/src/features/settings/SettingsRouteScreen.tsxapps/mobile/src/features/settings/components/SettingsLegalDocumentRouteScreen.tsxapps/mobile/src/features/settings/components/SettingsRow.tsxapps/mobile/src/features/settings/components/settings-sheet-targets.tsapps/mobile/src/features/settings/lib/legal-document-url.test.tsapps/mobile/src/features/settings/lib/legal-document-url.tsdocs/architecture/overview.mddocs/operations/ci.mddocs/operations/effect-fn-checklist.md
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccd10e8755
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merge activity
|
…pingdotgg#3978, pingdotgg#4001, pingdotgg#4020) (#156) ## What changed - Ports duty-cycle status animations and removes fixed noise overlay (`pingdotgg#3978`). - Ports onboarding/cloud connection status presentation fix (`pingdotgg#4001`). - Ports markdown over-indent list normalization (`pingdotgg#4020`). - Follow-up: allow Connect/Retry for saved cloud environments in idle/error tones (upstream left those buttons permanently disabled). - Preserves fork: keeps `sidebar-translucent` alongside upstream `surface-grain`. ## Validation - `vp check` / `vp run typecheck` — pass on stack tip - CI: pending Stack: 2 of 4; depends on #155.
3 participants
What changed
#3990,#3991,#3992).#3972) and the legal modal header crash fix (#4000)./legalindex (legal-index-page),wsNativeApiwording, CI command list clarity, remove empty code fence.ci.md.Validation
vp check/vp run typecheck— passStack: 1 of 4; base
main.