[codex] Fix onboarding connection status

[juliusmarminge]

Summary

The T3 Connect onboarding dialog treated any environment saved in the connection catalog as connected. When relay discovery succeeded enough to save an environment but the connection supervisor failed to reach its endpoint, onboarding displayed a disabled Connected button alongside a reconnect failure. This gave users contradictory and overly optimistic connection state.

Pass the saved environment presentations, including their live supervisor connection state, into the cloud environment rows. Saved environments now render Connected, Connecting…, Reconnecting…, Connection failed, Offline, or Not connected from the actual connection phase. Retry errors also drive the row text, tone, status dot, and tooltip. Catalog registration feedback now says the environment was added and that connection is starting instead of claiming the connection already succeeded.

The connection-phase presentation is isolated in a small pure module so every phase can be tested without mocking the connection supervisor or UI component.

Validation

• vp check
• vp run typecheck
• vp test run --passWithNoTests --project unit from apps/web (149 files, 1,285 tests)

Note

Fix onboarding connection status to show live state for saved cloud environments

• Saved cloud environments in the onboarding devices step and connections settings now display live connection state (Connected, Connecting…, Reconnecting…, Connection failed, Offline, Not connected) with matching dot color, ping animation, and status text, instead of always appearing as connected.
• Adds presentSavedCloudEnvironmentConnection in cloudEnvironmentConnectionPresentation.ts to map EnvironmentConnectionPresentation phases to button labels, status text, and tones.
• Replaces the savedEnvironmentIds prop (a set of IDs) with savedEnvironments (an array carrying live connection data) across CloudEnvironmentConnectRows, CloudRemoteEnvironmentRows, and ConnectionsSettings.
• The success toast copy changes from the previous message to

^{Macroscope summarized 626f502.}

---

Note

Low Risk
UI-only presentation and prop wiring in the web app; connection behavior is unchanged aside from clearer copy and status display.

Overview
Fixes misleading Connected UI when an environment was only saved to the catalog while the supervisor was still connecting or failing.

CloudEnvironmentConnectRows now takes savedEnvironments (id + live EnvironmentConnectionPresentation) instead of savedEnvironmentIds, with showSavedEnvironments replacing showSavedAsConnected. Saved rows use presentSavedCloudEnvironmentConnection for button label, status line, status dot color, ping animation, and tooltips; relay-only availability is used when the env is not saved yet.

Adds cloudEnvironmentConnectionPresentation.ts (phase → label/tone, reusing connectionStatusText) and unit tests. Onboarding DevicesStep and Connections settings pass full environment presentations. Success toast after register says Environment added / connection is starting, not that the link already succeeded.

^{Reviewed by Cursor Bugbot for commit 626f502. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7a8dfccb-3585-45f2-8443-1395eabbcdc7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-onboarding-connection-state

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a self-contained UI bug fix that displays accurate connection status (connecting, error, offline, etc.) during onboarding instead of always showing "Connected." The changes are purely presentational with comprehensive tests included.

^{You can customize Macroscope's approvability policy. Learn more.}