Skip to content

sync: port upstream native diff highlighter and macOS fullscreen titlebar (#4029, #4019) - #157

Merged
aaditagrawal merged 2 commits into
mainfrom
sync/20260716-mobile-desktop
Jul 16, 2026
Merged

sync: port upstream native diff highlighter and macOS fullscreen titlebar (#4029, #4019)#157
aaditagrawal merged 2 commits into
mainfrom
sync/20260716-mobile-desktop

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jul 16, 2026

Copy link
Copy Markdown
Owner

What changed

  • Ports native review-diff highlighter grammar-state isolation (#4029).
  • Ports macOS fullscreen titlebar spacing IPC/state plumbing (#4019).
  • Preserves fork: WSL desktop handling and log-dir IPC methods merged with fullscreen APIs.

Validation

  • vp check / vp run typecheck — pass on stack tip
  • CI: pending

Stack: 3 of 4; depends on #156.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aaditagrawal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8f524ec6-637f-4ba6-af83-4b91c52f0f86

📥 Commits

Reviewing files that changed from the base of the PR and between 0b2d906 and b7b9072.

📒 Files selected for processing (11)
  • apps/desktop/src/ipc/DesktopIpcHandlers.ts
  • apps/desktop/src/ipc/channels.ts
  • apps/desktop/src/ipc/methods/window.test.ts
  • apps/desktop/src/ipc/methods/window.ts
  • apps/desktop/src/preload.ts
  • apps/desktop/src/window/DesktopWindow.test.ts
  • apps/desktop/src/window/DesktopWindow.ts
  • apps/mobile/src/features/diffs/nativeReviewDiffHighlighter.test.ts
  • apps/mobile/src/features/diffs/nativeReviewDiffHighlighter.ts
  • apps/web/src/components/AppSidebarLayout.tsx
  • packages/contracts/src/ipc.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/20260716-mobile-desktop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Jul 16, 2026
@github-actions github-actions Bot added the size:L 100-499 effective changed lines (test files excluded in mixed PRs). label Jul 16, 2026
@aaditagrawal aaditagrawal changed the title Isolate native diff highlight grammar state (#4029) sync: port upstream native diff highlighter and macOS fullscreen titlebar (#4029, #4019) Jul 16, 2026
@aaditagrawal

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@aaditagrawal
aaditagrawal force-pushed the sync/20260716-mobile-desktop branch 2 times, most recently from 5c6da4e to 34b0027 Compare July 16, 2026 09:40
@aaditagrawal
aaditagrawal force-pushed the sync/20260716-web-ux branch from efbcae9 to 532cc95 Compare July 16, 2026 09:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34b00270a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +466 to +470
if (
segmentFile &&
(segmentFile.id !== file.id ||
(previousRow !== undefined &&
!canShareGrammarContext(previousRow, selectedRow, input.rows)))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve new-side context through replacements

When a hunk is context -> delete -> add and the context line opens multi-line syntax, the first addition is consecutive with that context in the new file, but this check compares it only with the immediately preceding deletion and flushes. The addition is then tokenized as a fresh segment, so visible review diffs can mis-highlight added lines inside multiline strings/comments until the token cache is reset; the highlighter needs to track old- and new-side grammar context separately or seed addition segments from the prior context.

Useful? React with 👍 / 👎.

@aaditagrawal
aaditagrawal force-pushed the sync/20260716-mobile-desktop branch from 34b0027 to 4025f28 Compare July 16, 2026 09:49
@aaditagrawal
aaditagrawal force-pushed the sync/20260716-web-ux branch from 532cc95 to 1bbec0c Compare July 16, 2026 09:49
@aaditagrawal
aaditagrawal force-pushed the sync/20260716-mobile-desktop branch from 4025f28 to 1ced949 Compare July 16, 2026 09:50
@aaditagrawal
aaditagrawal force-pushed the sync/20260716-web-ux branch from 1bbec0c to 3a2d533 Compare July 16, 2026 09:50

aaditagrawal commented Jul 16, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jul 16, 10:01 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 16, 10:05 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 16, 10:05 AM UTC: @aaditagrawal merged this pull request with Graphite.

@aaditagrawal
aaditagrawal changed the base branch from sync/20260716-web-ux to graphite-base/157 July 16, 2026 10:02
@aaditagrawal
aaditagrawal changed the base branch from graphite-base/157 to main July 16, 2026 10:03
@aaditagrawal
aaditagrawal force-pushed the sync/20260716-mobile-desktop branch from 1ced949 to b7b9072 Compare July 16, 2026 10:04
@aaditagrawal
aaditagrawal merged commit 1cfb01e into main Jul 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants