sync: port upstream native diff highlighter and macOS fullscreen titlebar (#4029, #4019) - #157
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
5c6da4e to
34b0027
Compare
efbcae9 to
532cc95
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34b00270a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| segmentFile && | ||
| (segmentFile.id !== file.id || | ||
| (previousRow !== undefined && | ||
| !canShareGrammarContext(previousRow, selectedRow, input.rows))) |
There was a problem hiding this comment.
Preserve new-side context through replacements
When a hunk is context -> delete -> add and the context line opens multi-line syntax, the first addition is consecutive with that context in the new file, but this check compares it only with the immediately preceding deletion and flushes. The addition is then tokenized as a fresh segment, so visible review diffs can mis-highlight added lines inside multiline strings/comments until the token cache is reset; the highlighter needs to track old- and new-side grammar context separately or seed addition segments from the prior context.
Useful? React with 👍 / 👎.
34b0027 to
4025f28
Compare
532cc95 to
1bbec0c
Compare
4025f28 to
1ced949
Compare
1bbec0c to
3a2d533
Compare
Merge activity
|
1ced949 to
b7b9072
Compare

What changed
#4029).#4019).Validation
vp check/vp run typecheck— pass on stack tipStack: 3 of 4; depends on #156.