Core: Re-add and deprecate HMS_TABLE_OWNER to TableProperties#6314
Conversation
4b95ec5 to
d314073
Compare
|
LGTM, makes sense! I tried to create a milestone for 1.3 to include deprecating TableProperties.HMS_TABLE_OWNER so that we won't forget, but I haven't found a way to create that milestone (I guess I lack permissions). I created the issue though, to drop this field. @Fokko could you please take a look if you can create that milestone? |
|
@gaborkaszab Sure, created and added 👍🏻 |
|
@Fokko Thanks for creating 1.3.0 milestone! However, I see you added this ticket to the milestone but this in fact is meant to be in 1.2.0 to deprecate that field, and #6316 is meant to be in 1.3.0 to drop it. I added it accordingly and removed this one. This PR requires immediate attention I guess as it breaks the build now. |
Fokko
left a comment
There was a problem hiding this comment.
I think restoring this is the easiest way to fix this. I through this was safe to delete, but it was part of the 1.1.0 release.
|
Thanks a lot for the fix |
This table property was shipped with 1.1.0 and then removed by #6045 before we configured RevAPI to compare against 1.1.0 in #6275
CI is currently failing on
masterwith:/cc @szehon-ho @haizhou-zhao