Add an option for skip type conversion#1234
Closed
cve wants to merge 3 commits into
Closed
Conversation
cve
changed the title
dunglas
requested changes
Jul 10, 2017
dunglas
left a comment
dunglas
left a comment
Member
There was a problem hiding this comment.
Can you also add at least a unit test?
| */ | ||
| private function shouldConvert(array $attributes = null): bool | ||
| { | ||
| foreach ((array) $attributes as $attribute) { |
Member
There was a problem hiding this comment.
Use less cast because of the typehint.
Author
There was a problem hiding this comment.
it seems to me, If attributes will be null then invalid argument supplied to foreach will be thrown, but if I do array attributes = [] then the cast will be use less, you are right, I will fix it, thanks
| } | ||
|
|
||
| $doctrineTypeName = $doctrineClassMetadata->getTypeOfField($propertyName); | ||
| if ($this->shouldConvert($propertyMetadata->getAttributes())) { |
Member
There was a problem hiding this comment.
Why don't you use the getAttribute method directly?
Author
There was a problem hiding this comment.
cause I didn't know about that :), I will fix it, thanks.
Merged
1 task
1 task
Merged
Contributor
|
Could you finish this please ? |
Author
|
#1478 is not it better? |
Member
Merged
Merged
This was referenced Nov 5, 2018
Merged
4 tasks
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm added an option to ApiProperty for attributes with "convert"=false, which skip converting doctrine type
@dunglas @sroze @theofidry