Skip to content

Better exception message#1403

Closed
greg0ire wants to merge 1 commit into
api-platform:2.1from
greg0ire:better_exception_message
Closed

Better exception message#1403
greg0ire wants to merge 1 commit into
api-platform:2.1from
greg0ire:better_exception_message

Conversation

@greg0ire

@greg0ire greg0ire commented Oct 9, 2017

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1234, #5678
License MIT
Doc PR api-platform/docs#1234

Getting "Not Found" on a GET route can get really confusing when the object is found but the format is not.

Getting "Not found" on a route where you are getting an object can get
real confusing.
@greg0ire greg0ire changed the base branch from master to 2.1 October 9, 2017 13:53

@dunglas dunglas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just put everything on the same line?

@greg0ire

greg0ire commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

Can you just put everything on the same line?

Sure, but I don't like it :P .

@greg0ire

greg0ire commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

Hmmm, github does not notice my push, weird...

Counting objects: 8, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 1.09 KiB | 0 bytes/s, done.
Total 8 (delta 7), reused 0 (delta 0)
remote: Resolving deltas: 100% (7/7), completed with 7 local objects.
To github.com:greg0ire/core.git
 + 8c5764a8...a28d7581 better_exception_message -> better_exception_message (forced update)

@dunglas

dunglas commented Oct 9, 2017

Copy link
Copy Markdown
Member

Missing commit?

I get the point about long lines, but we (mostly) keep in sync with Symfony CS.

@greg0ire

greg0ire commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

I think it really is GH having some issues: here is the commit I pushed: greg0ire@a28d758

@dunglas

dunglas commented Oct 9, 2017

Copy link
Copy Markdown
Member

Indeed, anyway, some related tests are failing.

@greg0ire

greg0ire commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

Yeah I fixed them too... let's just create a new PR then :(

@greg0ire greg0ire closed this Oct 9, 2017
@greg0ire

greg0ire commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

GH is showing the correct commit on my new branch, but says it is 40 minutes old... what the hell? greg0ire@fab102f

@greg0ire

greg0ire commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

And I cannot create a PR because it sees no difference with 2.1 .

@greg0ire

greg0ire commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

@dunglas Github is getting better, see #1405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants