fix: apply temp fix for react-native-navigation#1502#1
Merged
kevboh merged 1 commit intoOct 16, 2017
Merged
Conversation
|
The fix you are referring to is NOT a fix. Same guy posted a comment right below the "fix" you are referring to saying that it does not work on things like Lenovo tablet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From: wix#1502 (comment)
This is an awful "fix" but it's the only thing I can figure out that stops the crashes. It appears to be an issue with how
react-native-navigationinteracts withreact-native, the stack trace that you get on crash actually comes from inside ofreact-native.Note this will cause memory leaks and may cause some subtle bugs due to components in lightboxes not having their
componentWillUnmountcallback triggered.