fix: make FAB icon size larger#2
Merged
kevboh merged 1 commit intoOct 16, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
ScaleType.CENTERallows the FAB icon image to grow outside of its set bounds. I think this is because the FAB sets padding / margins on the ImageView that we actually want to ignore, so disabling scaling forces a larger size.This resolves the issue with the FAB icon image being too small. We may want to wrap this scale toggle behind a FAB param if we need the standard 24dp sized FAB icons anywhere else in the application.