Skip to content

feat(autoware_path_optimizer): meta-repository changes for acados#6771

Merged
xmfcx merged 46 commits intoautowarefoundation:mainfrom
PanConChicharron:arjun.ram/T4DEV-9960
Feb 17, 2026
Merged

feat(autoware_path_optimizer): meta-repository changes for acados#6771
xmfcx merged 46 commits intoautowarefoundation:mainfrom
PanConChicharron:arjun.ram/T4DEV-9960

Conversation

@PanConChicharron
Copy link
Copy Markdown
Contributor

@PanConChicharron PanConChicharron commented Feb 2, 2026

Description

Changes to include new libraries and dependencies required for new MPT.

rust and cargo are dependencies of acados and terra-renderer, respectively.

How was this PR tested?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Comment thread repositories/autoware.repos Outdated
@paulsohn paulsohn requested a review from TetsuKawa February 12, 2026 09:15
@paulsohn
Copy link
Copy Markdown
Collaborator

paulsohn commented Feb 12, 2026

@TetsuKawa I see you previously created TIER IV internal rust role. Would you mind reviewing this role and see if there's anything missing?

Comment thread repositories/autoware.repos Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Autoware meta-repository to support new MPT work by adding required external dependencies (acados + tera_renderer) and extends the dev-environment provisioning to install Rust tooling via Ansible.

Changes:

  • Add universe/external/acados and universe/external/tera_renderer entries to the autoware.repos manifest.
  • Add Ansible tasks to install rustup/Rust stable and update the toolchain as part of build_tools.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
repositories/autoware.repos Adds new external repositories (acados + tera_renderer) needed by the upcoming MPT integration.
ansible/roles/build_tools/tasks/main.yaml Provisions Rust via rustup and updates stable toolchain for build tooling requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ansible/roles/build_tools/tasks/main.yaml Outdated
Comment thread ansible/roles/build_tools/tasks/main.yaml Outdated
Comment thread ansible/roles/build_tools/tasks/main.yaml Outdated
Comment thread ansible/roles/build_tools/tasks/main.yaml Outdated
Comment thread ansible/roles/build_tools/tasks/main.yaml Outdated
Comment thread ansible/roles/build_tools/tasks/main.yaml Outdated
Copy link
Copy Markdown
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until web.auto team adds the support for vcs import --recursive flag support, we cannot merge this.

@PanConChicharron
Copy link
Copy Markdown
Contributor Author

Until web.auto team adds the support for vcs import --recursive flag support, we cannot merge this.

This has been completed.

However, setup fails due to an issue with installing rustup. Looking into it now.

Comment thread ansible/roles/rust/README.md Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ansible/roles/rust/tasks/main.yaml Outdated
Comment thread ansible/playbooks/openadkit.yaml Outdated
Comment thread ansible/roles/rust/tasks/main.yaml Outdated
Comment thread ansible/roles/rust/README.md Outdated
Comment thread ansible/roles/rust/tasks/main.yaml Outdated
Comment thread ansible/roles/rust/tasks/main.yaml Outdated
Comment thread ansible/roles/rust/tasks/main.yaml Outdated
Comment thread ansible/roles/rust/tasks/main.yaml Outdated
Comment thread repositories/autoware.repos
@paulsohn
Copy link
Copy Markdown
Collaborator

paulsohn commented Feb 17, 2026

@PanConChicharron I found that rustc and cargo can be apt installed but rustup is not.

So maybe we can install rustc and cargo of fixed version from apt. The latest version available for Ubuntu 22.04 is 1.89.0.

@PanConChicharron PanConChicharron force-pushed the arjun.ram/T4DEV-9960 branch 2 times, most recently from 8bd9357 to f51e4e8 Compare February 17, 2026 06:03
Comment thread ansible/roles/rust/tasks/main.yaml Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ansible/roles/rust/README.md
Comment thread ansible/roles/rust/tasks/main.yaml
Comment thread ansible/roles/rust/README.md Outdated
PanConChicharron and others added 5 commits February 17, 2026 16:16
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
@PanConChicharron
Copy link
Copy Markdown
Contributor Author

Had to rebase and force-push, as changes suggested by CodePilot do not pass DCO

Comment thread repositories/autoware-nightly.repos Outdated
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Comment thread repositories/autoware.repos Outdated
@xmfcx xmfcx self-requested a review February 17, 2026 07:53
This reverts commit d2a892b.

Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Signed-off-by: Arjun Jagdish Ram <arjun.ram@tier4.jp>
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Copy link
Copy Markdown
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the web.auto is updated, we can proceed to merge it.

I tested the ansible playbook locally and it works.

Image

Once it is merged, I'll test it with web.auto evaluator

@paulsohn
Copy link
Copy Markdown
Collaborator

@xmfcx webauto is already updated, so it seems no problem to proceed.

@xmfcx xmfcx requested a review from paulsohn February 17, 2026 08:36
@paulsohn
Copy link
Copy Markdown
Collaborator

paulsohn commented Feb 17, 2026

@xmfcx I don't have a write permission for autoware metarepo, so you would need another reviewer 🫠

@xmfcx xmfcx merged commit 73ee57b into autowarefoundation:main Feb 17, 2026
15 of 17 checks passed
xmfcx added a commit that referenced this pull request Feb 20, 2026
xmfcx added a commit that referenced this pull request Feb 21, 2026
* revert: "feat(ansible)!: install rust through rustup instead of apt (#6825)"

This reverts commit ef1fcb9.

* revert: "feat(autoware_path_optimizer): meta-repository changes for acados (#6771)"

This reverts commit 73ee57b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants