Show appropriate bot cards in the user thread list

[sheriffjimoh]

Summary by Sourcery

Fetch bot categories based on the user ID to display relevant bot cards in the user thread list.

New Features:

• Display relevant bot cards in the user thread list.

Enhancements:

• Use the user ID to fetch bot categories.

Summary by CodeRabbit

• Bug Fixes

  • Enhanced sidebar personalization to display categories more accurately, ensuring a smoother and more reliable user experience.

• Chores

  • Removed unnecessary dependency from the project to streamline functionality and reduce complexity.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the sidebar to display bot cards in the user thread list. It fetches categories based on the user ID, and adds remark-gfm to the dependencies.

Sequence diagram for fetching user categories

sequenceDiagram
    participant C as Client
    participant S as SidebarProvider
    participant U as UserService
    participant Cat as CategoryService

    C->>S: Initialize
    alt has slug
        S->>U: getUserBySlug(slug, isSameUser)
        U-->>S: return user data
        S->>Cat: getCategories(userId)
    else no slug
        S->>Cat: getCategories(null)
    end
    Cat-->>S: return categories
    S->>S: format categories object
    S-->>C: return formatted categories

Loading

Class diagram for sidebar provider changes

classDiagram
    class SidebarProvider {
        -loading: boolean
        -error: Error
        +useAsync()
        +getUserBySlug(slug: string, isSameUser: boolean)
        +getCategories(userId: string)
    }

    class CategoryResponse {
        +categoryId: string
        +other properties
    }

    SidebarProvider ..> CategoryResponse : returns

Loading

File-Level Changes

Change	Details	Files
Fetch categories based on the user ID.	Call getCategories with the userId. Simplify the logic for assigning the userId.	apps/masterbots.ai/lib/hooks/use-sidebar.tsx
Add remark-gfm to the dependencies.	Add remark-gfm: ^4.0.0 to the dependencies.	package.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
masterbots	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 11, 2025 4:42pm

[coderabbitai]

Walkthrough

This pull request introduces modifications to the useAsync hook in the SidebarProvider component of the use-sidebar.tsx file to enhance how user-specific categories are fetched. The logic now checks for a defined slug, retrieves user data with improved error handling, and conditionally assigns the userId before calling the getCategories function. Additionally, the package.json file has been updated to remove the dependency on remark-gfm, simplifying the project's dependencies.

Changes

File(s)	Change Summary
apps/masterbots.ai/lib/hooks/use-sidebar.tsx	Modified logic in the useAsync hook: checks for slug, fetches user data with error handling, conditionally assigns userId, and passes it to getCategories for tailored category retrieval.
package.json	Removed the dependency "remark-gfm": "^4.0.0" while retaining existing dependencies like axios.
apps/masterbots.ai/services/hasura/hasura.service.ts	Updated getCategories function to include conditional arguments for filtering categories based on the presence of userId, enhancing query capabilities.

Possibly related PRs

• Improve seo sitemap #306: Modifications to the getCategories function to include userId for tailored category retrieval.
• Add chat publicity trigger #258: Introduction of the UpdateThreadVisibility function, related to user context handling within the hasura.service.ts file.
• Fix observations from Jun #353: Adjustments to category retrieval logic based on user context, enhancing filtering capabilities.

Suggested labels

enhancement

Suggested reviewers

• AndlerRL
• Bran18

Poem

I’m a rabbit hopping along,
Coding changes all day long,
Fetching users with care and flair,
Tailoring categories with love to share,
With remark-gfm now out of sight—
Celebrate the change, it feels just right! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/masterbots.ai/services/hasura/hasura.service.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/masterbots.ai/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @sheriffjimoh - I've reviewed your changes - here's some feedback:

Overall Comments:

• Maintain consistent code style by using a spaced 'if (slug)' syntax and simplify 'user ? user?.userId : null' to 'user?.userId'.
• Verify that getCategories correctly handles a null userId since the API now relies on passing that parameter.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/masterbots.ai/lib/hooks/use-sidebar.tsx (1)

86-86: Consider adding error handling for getCategories.

While the user fetching has proper error handling, the getCategories call should also handle potential errors to maintain consistency.

-   const categories = await getCategories(userId)
+   const { categories, error: categoriesError } = await getCategories(userId)
+   if (categoriesError) throw categoriesError

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfb5ea8 and 37af200.

⛔ Files ignored due to path filters (1)

• bun.lockb is excluded by !**/bun.lockb

📒 Files selected for processing (2)

• apps/masterbots.ai/lib/hooks/use-sidebar.tsx (1 hunks)
• package.json (1 hunks)

🔇 Additional comments (2)

apps/masterbots.ai/lib/hooks/use-sidebar.tsx (1)

76-84: LGTM! User fetching logic looks good.

The implementation correctly:

• Handles the case when slug is undefined
• Fetches user data with proper error handling
• Safely assigns userId based on the user object existence

package.json (1)

31-32: Verify if remark-gfm is required for this PR.

The addition of remark-gfm (GitHub Flavored Markdown parser) seems unrelated to the PR objective of showing appropriate bot cards in the user thread list. If this dependency is needed for a different feature, consider moving it to a separate PR.

[AndlerRL]

Excellent! Good way to deal with the categories per page 😎 now we need to work with the chatbots, I see that we show the availabel categories but we are still showing the bots that user hasn't done conversation with. There is a render issue that is not showing the empty list message, but you can notice that the list won't change were no threads were found with the selected bot and when it does, the list updates.

Can you apply the improvement mentioned above? 🙏 after that and the observation and we will be good to go! 👍

[coderabbitai]

Actionable comments posted: 0

🔭 Outside diff range comments (1)

apps/masterbots.ai/services/hasura/hasura.service.ts (1)

43-90: 🛠️ Refactor suggestion

Add consistent error handling pattern.

The function should follow the same error handling pattern used in other functions like getUserBySlug to ensure consistent error management across the service.

 export async function getCategories(userId?: string): Promise<Category[]> {
+  try {
     const client = getHasuraClient({})
     const { category } = await client.query({
       // ... existing query
     })
     return category as Category[]
+  } catch (error) {
+    console.error('Error fetching categories:', error)
+    throw error
+  }
 }

🧹 Nitpick comments (2)

apps/masterbots.ai/services/hasura/hasura.service.ts (2)

43-90: Add TypeScript return type annotation for better type safety.

The function implementation looks good, but could benefit from explicit TypeScript return type annotation.

-export async function getCategories(userId?: string) {
+export async function getCategories(userId?: string): Promise<Category[]> {

---

43-90: Consider extracting common GraphQL fragments.

To improve maintainability and reduce duplication, consider extracting common query structures into reusable GraphQL fragments.

Example:

const CATEGORY_FIELDS = `
  categoryId
  name
  chatbots {
    chatbot {
      __scalar
      prompts {
        prompt {
          __scalar
        }
      }
    }
    __scalar
  }
`

export async function getCategories(userId?: string): Promise<Category[]> {
  // Use CATEGORY_FIELDS in the query
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37af200 and 2ba5b9d.

📒 Files selected for processing (2)

• apps/masterbots.ai/services/hasura/hasura.service.ts (1 hunks)
• package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• package.json

🔇 Additional comments (1)

apps/masterbots.ai/services/hasura/hasura.service.ts (1)

43-90: LGTM! Appropriate authentication requirements.

The function correctly handles public data access without requiring authentication, which is suitable for category listing.

[sheriffjimoh]

Excellent! Good way to deal with the categories per page 😎 now we need to work with the chatbots, I see that we show the availabel categories but we are still showing the bots that user hasn't done conversation with. There is a render issue that is not showing the empty list message, but you can notice that the list won't change were no threads were found with the selected bot and when it does, the list updates.

Can you apply the improvement mentioned above? 🙏 after that and the observation and we will be good to go! 👍

@AndlerRL - all fixed ✌️

[AndlerRL]

LGTM! Thanks for dealing with the chabots details 👍 looks very good the thread list options. Merging!

[AndlerRL]

Jimoh Development Support - February 2025

[AndlerRL]

Show Appropriate Bot Cards In the User Thread List