Resolve followee permission error so that moderator too can follow and unfollow

[sheriffjimoh]

Summary by Sourcery

Allow moderators to follow and unfollow users.

Bug Fixes:

• Fixed an issue where moderators were unable to follow or unfollow users.

Enhancements:

• Improved the error message displayed when following or unfollowing a user fails.

Summary by CodeRabbit

• Bug Fixes

  • Updated follow/unfollow error handling to display a consistent, user-friendly message upon failure.
  • Adjusted the loading indicator to appear only when actions are actively processing.

• Chores

  • Enhanced permission settings for the social following feature to improve access control.
  • Modified layout attributes in the chat details skeleton for better visual consistency.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
masterbots	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 11, 2025 7:44pm

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request resolves the permission error affecting moderators by updating the permission configuration in the Hasura metadata. The changes ensure that users (including moderators) cannot follow themselves, and the permission checks now verify that the followee is not the same as the follower. Additionally, the pull request refines the error messaging and loading UI in the user card component to improve user feedback and interface behavior.

Sequence Diagram for Follow/Unfollow Request Flow

sequenceDiagram
    actor User
    participant UserCard
    participant API

    User->>UserCard: Click Follow/Unfollow
    UserCard->>API: Send follow/unfollow request
    API-->>UserCard: Return success or permission error
    alt Success
      UserCard->>User: Update UI (follow state changed)
    else Error
      UserCard->>User: Show error: "Failed to process your request, try again!"
    end

Loading

ER Diagram for Updated public_social_following Permissions

erDiagram
    PUBLIC_SOCIAL_FOLLOWING {
        string follower_id "Must equal X-Hasura-User-Id"
        string followee_id "Must NOT equal X-Hasura-User-Id"
        string followee_id_chatbot
    }

    %% Note: The permission rules enforce that a user cannot follow themselves, ensuring followee_id is not the same as follower_id.

Loading

File-Level Changes

Change	Details	Files
Updated permission checks in the Hasura metadata configuration	Modified the insert_permissions to check that the followee ID is not equal to the current user's ID. Updated the update_permissions filter to enforce that the followee ID should not equal the current user's ID, along with verifying the follower ID.	apps/hasura/metadata/databases/masterbots/tables/public_social_following.yaml
Refined UI feedback and loading behavior in the user card component	Changed the error text in the follow/unfollow action from a direct failure message to a more generic failure prompt. Adjusted the condition and container styling for displaying the loading skeleton, removing the check for a missing user.	apps/masterbots.ai/components/routes/profile/user-card.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Walkthrough

This pull request updates the Hasura metadata and UI logic. The metadata file for the social_following table has been modified to adjust role-based permissions using non-equality checks and combined logical conditions. In the UI, the error handling in the follow/unfollow process has been revised to display a static error message, and the loading state condition in the user card component has been streamlined to depend solely on the loading flag.

Changes

File(s)	Change Summary
apps/hasura/.../public_social_following.yaml	Updated permissions for the social_following table: changed insert, update, and select conditions for moderator and user roles using _neq and logical operators.
apps/masterbots.ai/components/.../user-card.tsx	Refined error handling and conditional rendering: replaced dynamic error messages with a static message and adjusted the loading condition to rely only on loading.
apps/masterbots.ai/components/.../chat-chatbot-details-skeleton.tsx	Modified outer <div> class attributes by removing height calculation, affecting overall layout without altering internal structure.

Possibly related PRs

• feat(db): create social following table. #292: Establishes the social_following table and its initial permissions, forming a code-level basis for the permission changes in this PR.

Suggested labels

enhancement

Suggested reviewers

• AndlerRL
• Bran18

Poem

I'm a hopping rabbit, coding through the night,
Tweaking permissions and messages just right.
YAML and JSX now prance in a refined flow,
With static errors that gently glow.
Hopping along, I celebrate this light update—code's magic, truly great! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/masterbots.ai/components/routes/profile/user-card.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/masterbots.ai/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

apps/masterbots.ai/components/shared/skeletons/chat-chatbot-details-skeleton.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/masterbots.ai/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @sheriffjimoh - I've reviewed your changes - here's some feedback:

Overall Comments:

• The error message in UserCard should provide more context to the user.
• It's good to see the addition of _neq: X-Hasura-User-Id to prevent users from following themselves.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8db89f1 and 8cf9dfc.

📒 Files selected for processing (2)

• apps/masterbots.ai/components/routes/profile/user-card.tsx (2 hunks)
• apps/masterbots.ai/components/shared/skeletons/chat-chatbot-details-skeleton.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/masterbots.ai/components/routes/profile/user-card.tsx

[AndlerRL]

LGTM! The change makes total sense for the followee insert validation! We need to test this out to confirm the changes however, we can test this once it is in the develop branch. @AnoukRImola can collaborate on verifying the changes.

I found only one observation though I added it as a comment due we just need to confirm the coderabbitai comment. After that, it will be good to go!

[AndlerRL]

Jimoh Development Support - February 2025

[AndlerRL]

Resolve Followee Permission Error