yAxisPosition for line chart#745
Open
Faiyyaz wants to merge 330 commits into
Open
Conversation
When the data is negative value in BarChart, the corresponding bar is rendered to downward from 0.
* Draw BarChart and LineChart from 0 * Add prop `fromZero` Add prop `fromZero` to BarChart and LineChart to render the charts from 0 not from the minimum value.
* update app.json to have sdkVersion if sdkVersion is not present, expo will use the latest version installed on the computer vs the one from package.json * update line-chart.js to fix onPress handler logic * change larger click circle to not rely on the fill to have opacity * remove Circles from View that were making them not show up in iOS
* Hide Horizontal and Vertical Labels * improve docs
* Add labels to progress chart * Refactoring to make this a non-breaking change
…hart-kit#141) * fix: update paths-js library version to fix pie chart with empty values * fix: fix NaN labels on pie charts with empty values
Please look into this and approve as I was not able to proceed or I will have to change the plugin thanks
* added background opacity props * updated README: added new opacity options 'backgroundGradientFromOpacity' and 'backgroundGradientToOpacity'.
…Legend prop is passed (chart-kit#479)
Co-authored-by: Herman Starikov <Hermanstarikov@gmail.com>
Co-authored-by: Herman Starikov <Hermanstarikov@gmail.com>
Co-authored-by: Robert <robertogarciadevelopment@gmail.com>
…fromNumber are set (chart-kit#575)
…ment for options” (chart-kit#523) To fix React Native Error: “Animated.event now requires a second argument for options”
…chart-kit#515) * Rework X axis labeling to allow dissimilar dataset lengths * Add prepare script for GitHub sourced library usage (builds on install)
* feat(line-chart): add fillShadowGradient To and From * feat(line-chart): set fillShadowGradientToOpacity * feat(line-chart): maintain backwards compatibility * feat(readme): update chart style object docs * feat(abstract): update option comments * feat(abstract): add offset options * feat(readme): update documentation * feat(readme): update documentation * feat(package): specify dependency resolutions * feat(abstract-chart): fix backwards compatibility Co-authored-by: Ezra Burga <ezra.burga@deepwatch.com>
yAxisPosition for label position
|
Maintainer triage note: the use case is reasonable, but I would not merge this implementation as-is. The API is split between Recommendation: worth revisiting as a focused feature PR with a cleaner API, visual examples, and current |
ghost
force-pushed
the
master
branch
3 times, most recently
from
bc0b8af to
096eeb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @olegberman I have added an optional prop called
yAxisPositionwhich can take a string value of eitherleftorright. The purpose of this is suppose we want to stack 2 line chart and still want to keep the y axis for both the chart then we need a config to put the yAxisPosition asrightfor one of the chart.Please refer sample screenshot