Skip to content

Test against new ros-dev image#2438

Open
Dreamsorcerer wants to merge 3 commits into
mainfrom
Dreamsorcerer-patch-2
Open

Test against new ros-dev image#2438
Dreamsorcerer wants to merge 3 commits into
mainfrom
Dreamsorcerer-patch-2

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the pinned ros-dev container digest to a new image version and makes the ROS environment-sourcing step in CI adaptive by replacing the hardcoded humble distro name with the $ROS_DISTRO environment variable (which the ROS container already exports).

  • docker/ros-dev-pin/Dockerfile: Updates the @sha256: digest to point to the new ros-dev image; the :latest tag is preserved so Dependabot can continue tracking updates.
  • .github/workflows/ci.yml: Replaces /opt/ros/humble/setup.bash with /opt/ros/${ROS_DISTRO}/setup.bash, making the sourcing step work correctly regardless of which ROS distro the container ships.

Confidence Score: 5/5

Safe to merge — both changes are narrow, well-scoped, and consistent with the existing workflow design.

The digest bump is a routine image update, and replacing the hardcoded humble distro with $ROS_DISTRO correctly adapts to whatever distro the new image ships. The $ROS_DISTRO variable is already relied upon by the surrounding step (it is echoed into GITHUB_ENV), so it is guaranteed to be present in the container environment. The step is also gated to Linux-only runners, keeping macOS paths unaffected.

No files require special attention.

Important Files Changed

Filename Overview
docker/ros-dev-pin/Dockerfile Routine digest bump to the new ros-dev image; structure and comments unchanged.
.github/workflows/ci.yml Makes the ROS setup path use $ROS_DISTRO instead of hardcoded "humble"; $ROS_DISTRO is already expected by the surrounding step logic.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[compute-ros-pin job] -->|reads sha256 digest| B[docker/ros-dev-pin/Dockerfile]
    B -->|outputs digest| C[self-hosted-tests job]
    C -->|Linux runner| D[Container: ghcr.io/dimensionalos/ros-dev@sha256:...]
    D -->|container sets ROS_DISTRO env var| E[Source ROS environment step]
    E -->|source /opt/ros/ROS_DISTRO/setup.bash| F[Export PYTHONPATH, AMENT_PREFIX_PATH, etc to GITHUB_ENV]
    F --> G[Run pytest]
    C -->|macOS runner| H[Host runner - no container]
    H -->|skips ROS sourcing step| G
Loading

Reviews (3): Last reviewed commit: "Update ci.yml" | Re-trigger Greptile

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant