Set maximum mono version to the Cycle 8 mono version. - #1118
Merged
Conversation
rolfbjarne
added
the
requires-approval-before-merge
Contributor
|
Build failure |
This fixes mmp tests that fail when a Cycle 9 mono version is installed on the bots: ``` Undefined symbols for architecture i386: "_mono_btls_bio_flush", referenced from: -u command line option [...] ld: symbol(s) not found for architecture i386 clang: error: linker command failed with exit code 1 (use -v to see invocation) MMP: error MM5109: Native linking failed with error code 1. Check build log for details. Task "Mmp" execution -- FAILED Done building target "_CompileToNative" in project "/Users/builder/data/lanes/3969/1d0df24f/source/xamarin-macios/tests/mmptest/regression/system-mono/system-mono.csproj".-- FAILED Done building project "/Users/builder/data/lanes/3969/1d0df24f/source/xamarin-macios/tests/mmptest/regression/system-mono/system-mono.csproj".-- FAILED ```
rolfbjarne
force-pushed
the
fix-mono-version-cycle8
branch
from
November 4, 2016 08:32
83e1f82 to
dce3ba2
Compare
Contributor
|
Build success |
Contributor
|
@pjcollins this will fix the mmp tests (even XM is not released from that branch) |
Contributor
|
Confirmed with @pjcollins |
rolfbjarne
added a commit
that referenced
this pull request
Nov 7, 2018
Commit list for xamarin/maccore: * xamarin/maccore@b73904c97b [docfixer] Create project files and fix a few issues. Fixes #1118. * xamarin/maccore@714bd73a55 [docfixer] Avoid declaring the same target twice. * xamarin/maccore@34f4bfa339 [populate] Directories need to call Directory.Exists for existence checks. * xamarin/maccore@341333db88 [docs] Remove truly ancient and outdated targets to publish updated docs. * xamarin/maccore@9e8f1a2f87 Merge pull request #1113 from xamarin/swift-o-matic-constructor-parameters * xamarin/maccore@6a700ab045 conditionally install cmake * xamarin/maccore@a10decc965 When you comment out dead code, it's dead - get rid of it, Steve. * xamarin/maccore@69d6c73ad6 Won't work without the new compiler. * xamarin/maccore@5bee7bce59 Cleaned up some of the public name handling. I wrote those predicates for a reason! * xamarin/maccore@208b159cf4 And the tests... * xamarin/maccore@1bfac97f9a Redoing public private names. Diff: xamarin/maccore@e73094e...b73904c
rolfbjarne
added a commit
that referenced
this pull request
Nov 21, 2018
Commit list for xamarin/maccore: * xamarin/maccore@6e9b63e537 Merge pull request #1162 from rolfbjarne/docfixer-fixes * xamarin/maccore@4cf1d63b7b [docfixer] Create project files and fix a few issues. Fixes #1118. * xamarin/maccore@714bd73a55 [docfixer] Avoid declaring the same target twice. * xamarin/maccore@34f4bfa339 [populate] Directories need to call Directory.Exists for existence checks. * xamarin/maccore@341333db88 [docs] Remove truly ancient and outdated targets to publish updated docs. Diff: xamarin/maccore@7ba9c5a...6e9b63e
rolfbjarne
added a commit
that referenced
this pull request
Nov 21, 2018
* Bump maccore to get fix for test-docs. Commit list for xamarin/maccore: * xamarin/maccore@6e9b63e537 Merge pull request #1162 from rolfbjarne/docfixer-fixes * xamarin/maccore@4cf1d63b7b [docfixer] Create project files and fix a few issues. Fixes #1118. * xamarin/maccore@714bd73a55 [docfixer] Avoid declaring the same target twice. * xamarin/maccore@34f4bfa339 [populate] Directories need to call Directory.Exists for existence checks. * xamarin/maccore@341333db88 [docs] Remove truly ancient and outdated targets to publish updated docs. Diff: xamarin/maccore@7ba9c5a...6e9b63e * [jenkins] Make it possible to force docs testing by applying a label to pull requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes mmp tests that fail when a Cycle 9 mono version is installed on the bots: