Add and ship file that lists the SDK versions XI/XM supports. by rolfbjarne · Pull Request #1162 · dotnet/macios

rolfbjarne · 2016-11-10T18:26:05Z

Add and ship a file that lists the SDK versions of the various SDKs XI supports.

Also list the minimum SDK version for each extension.

And add a script that verifies that the current SDK version is in this file,
which should ensure every SDK version bump ends up in the file.

Add and ship a file that lists the SDK versions of the various SDKs XI supports. Also list the minimum SDK version for each extension. And add a script that verifies that the current SDK version is in this file, which should ensure every SDK version bump ends up in the file.

rolfbjarne · 2016-11-10T18:28:38Z

@VincentDondain @jstedfast @emaf I believe this is useful for you. Please let me know if you want a different format or more data.

This is now a plist, which ends up here:

/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/SdkVersions.plist

spouliot

I had not thought about having the list of supported extensions. While it's nice to have the information handy I wonder how that can be used, as the templates must already have a similar logic (I assume) and they are not shipped with XI.

spouliot · 2016-11-10T19:12:00Z

+			<string>9.2</string>
+			<string>9.3</string>
+			<string>10.0</string>
+			<string>10.1</string>


tvOS 10.1 is part of Xcode 8.2

spouliot · 2016-11-10T19:13:07Z

@@ -0,0 +1,99 @@
+<?xml version="1.0" encoding="UTF-8"?>


should not this file one generated (and not checked in) ?

spouliot · 2016-11-10T19:13:54Z

+			<string>9.2</string>
+			<string>9.3</string>
+			<string>10.0</string>
+			<string>10.1</string>


same (or better here)

master supports iOS 10.1 (but not 10.2).

spouliot · 2016-11-10T19:16:00Z

+
+if (doc.SelectSingleNode ($"/plist/dict/dict/key[text()='tvOS']/following-sibling::array/string[text()='{args [3]}']") == null) {
+	Console.Error.WriteLine ($"Could not find the tvOS version {args [3]} in SdkVersions.plist.in.");
+	failed = true;


that failed to detect the tvOS 10.1 when the maximum is 10.0, OTOH that should not be the most common mistake

spouliot · 2016-11-10T19:16:55Z

+			<string>9.0</string>
+			<string>9.1</string>
+			<string>9.2</string>
+			<string>9.3</string>


IIRC there was no 9.3 since tvOS lagged by 0.1 with iOS version numbers last year

spouliot · 2016-11-10T19:23:27Z

@chamons XM should have something similar so your feedback is welcome too.

monojenkins · 2016-11-10T19:25:03Z

Build failure

chamons · 2016-11-10T19:36:49Z

@spouliot I agree. That first entails XM getting our act together and officially determining what SDKs we test with / claim to support.

It'll take at least a bit of research. Filed card here so I don't forget -

https://trello.com/c/Q9Y0WHwR/309-figure-out-sdk-version-question-and-add-to-plist-file

Let me get back to you. Don't hold this up for XM if it takes a bit.

…tween min and max, and that both min and max are in the list.

rolfbjarne · 2016-11-11T10:02:15Z

@spouliot it's not really a list of supported extensions, it's a list of min version for each extension (so that the IDE can compute the correct list of min deployment targets for those extensions).

monojenkins · 2016-11-11T11:01:00Z

Build failure

jstedfast · 2016-11-11T13:52:51Z

@Rolf awesome! The information in the SdkVersions.plist looks fantastic. I cannot think of anything else we need.

chamons · 2016-11-11T17:33:44Z

Ok, since it's just a list of os's we support, XM would be 10.7 -> 10.12 right now.

Talking to @rolfbjarne on Slack makes it sounds like we'll need a separate file in /Library/Frameworks/Xamarin.Mac.framework for the mac bits.

monojenkins · 2016-11-11T19:32:15Z

Build success

VincentDondain · 2016-11-14T15:22:07Z

To add on Sebastien's previous comment:

I had not thought about having the list of supported extensions. While it's nice to have the information handy I wonder how that can be used, as the templates must already have a similar logic (I assume) and they are not shipped with XI.

While the info seems handy, I don't see right now the use of the extensions min versions. The iOS extension wizard actually doesn't yet let people select a target minimum iOS version but it's gonna change soon. At that time, what we'll likely do (same as iOS templates) is have each extension template define its own minimum iOS version.

Though, it likely doesn't hurt to have it, maybe there's a usage I can't think of right now.

Other than that, the other lists look good to me.

rolfbjarne · 2016-11-14T15:31:42Z

Though, it likely doesn't hurt to have it, maybe there's a usage I can't think of right now.

I was thinking about the Plist editor, where you get a list of the valid minimum deployment targets.

monojenkins · 2016-11-14T21:19:32Z

Build success

VincentDondain · 2016-11-17T13:31:53Z

@rolfbjarne yes excellent point that would totally work and we absolutely don't do that right now.

spouliot · 2016-11-22T13:40:18Z

@rolfbjarne lgtm 👍

Commit list for xamarin/maccore: * xamarin/maccore@6e9b63e537 Merge pull request #1162 from rolfbjarne/docfixer-fixes * xamarin/maccore@4cf1d63b7b [docfixer] Create project files and fix a few issues. Fixes #1118. * xamarin/maccore@714bd73a55 [docfixer] Avoid declaring the same target twice. * xamarin/maccore@34f4bfa339 [populate] Directories need to call Directory.Exists for existence checks. * xamarin/maccore@341333db88 [docs] Remove truly ancient and outdated targets to publish updated docs. Diff: xamarin/maccore@7ba9c5a...6e9b63e

* Bump maccore to get fix for test-docs. Commit list for xamarin/maccore: * xamarin/maccore@6e9b63e537 Merge pull request #1162 from rolfbjarne/docfixer-fixes * xamarin/maccore@4cf1d63b7b [docfixer] Create project files and fix a few issues. Fixes #1118. * xamarin/maccore@714bd73a55 [docfixer] Avoid declaring the same target twice. * xamarin/maccore@34f4bfa339 [populate] Directories need to call Directory.Exists for existence checks. * xamarin/maccore@341333db88 [docs] Remove truly ancient and outdated targets to publish updated docs. Diff: xamarin/maccore@7ba9c5a...6e9b63e * [jenkins] Make it possible to force docs testing by applying a label to pull requests.

dnfclas added the cla-already-signed label Nov 10, 2016

spouliot suggested changes Nov 10, 2016

View reviewed changes

rolfbjarne added 3 commits November 11, 2016 10:20

[mtouch] Remove generated file from source control.

1d70ffb

[SdkVersions] Remove versions not in master yet.

64c4cf9

[SdkVersions] Improve detection script to verify that versions are be…

3612d08

…tween min and max, and that both min and max are in the list.

rolfbjarne force-pushed the sdk-versions branch from afa7853 to 3612d08 Compare November 11, 2016 09:59

Move things around a bit and add macOS support.

1839f18

rolfbjarne changed the title ~~Add and ship file that lists the SDK versions XI supports.~~ Add and ship file that lists the SDK versions XI/XM supports. Nov 11, 2016

Update Versions-mac.plist.in with extension info

0dbb086

spouliot approved these changes Nov 22, 2016

View reviewed changes

rolfbjarne merged commit 3a771ea into dotnet:master Nov 22, 2016

rolfbjarne mentioned this pull request Nov 21, 2018

Bump maccore to get fix for test-docs. #5163

Merged

Uh oh!

Conversation

rolfbjarne commented Nov 10, 2016

Uh oh!

rolfbjarne commented Nov 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spouliot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spouliot commented Nov 10, 2016

Uh oh!

monojenkins commented Nov 10, 2016

Uh oh!

chamons commented Nov 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rolfbjarne commented Nov 11, 2016

Uh oh!

monojenkins commented Nov 11, 2016

Uh oh!

jstedfast commented Nov 11, 2016

Uh oh!

chamons commented Nov 11, 2016

Uh oh!

monojenkins commented Nov 11, 2016

Uh oh!

VincentDondain commented Nov 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rolfbjarne commented Nov 14, 2016

Uh oh!

monojenkins commented Nov 14, 2016

Uh oh!

VincentDondain commented Nov 17, 2016

Uh oh!

spouliot commented Nov 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rolfbjarne commented Nov 10, 2016 •

edited

Loading

chamons commented Nov 10, 2016 •

edited

Loading

VincentDondain commented Nov 14, 2016 •

edited

Loading