Bump maccore to get fix for test-docs. - #5163
Merged
Merged
Conversation
Commit list for xamarin/maccore: * xamarin/maccore@6e9b63e537 Merge pull request #1162 from rolfbjarne/docfixer-fixes * xamarin/maccore@4cf1d63b7b [docfixer] Create project files and fix a few issues. Fixes #1118. * xamarin/maccore@714bd73a55 [docfixer] Avoid declaring the same target twice. * xamarin/maccore@34f4bfa339 [populate] Directories need to call Directory.Exists for existence checks. * xamarin/maccore@341333db88 [docs] Remove truly ancient and outdated targets to publish updated docs. Diff: xamarin/maccore@7ba9c5a...6e9b63e
…to pull requests.
rolfbjarne
added
run-internal-tests
Contributor
|
Build success |
spouliot
reviewed
Nov 21, 2018
spouliot
left a comment
spouliot
left a comment
Contributor
There was a problem hiding this comment.
The current output is not very specific about what happened and clicking on the Tests failed does not show anything red.
Collaborator
|
✅ Jenkins job (on internal Jenkins) succeeded ✅ Build succeeded |
Member
Author
There are two issues here:
None of these are related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make it possible to force docs testing by applying a label to pull requests.
Fixes https://github.com/xamarin/maccore/issues/1118.
Commit list for xamarin/maccore:
Diff: https://github.com/xamarin/maccore/compare/7ba9c5a962c1fcdeb651488e7459e89f3c9932fd...6e9b63e53755a74138b78dafd098836a79660edd