[Test][Intro] Fix introspection test on API changes for Xcode 9 Beta 1 - #2191
Merged
Conversation
spouliot
suggested changes
Jun 9, 2017
|
|
||
| #if XAMCORE_4_0 | ||
| [DisableDefaultCtor] // -init should never be called on NSUnit! | ||
| #endif |
Contributor
There was a problem hiding this comment.
It's better not to be under 4_0
And add manual, empty ctor in another files (all excluded in 4_0) along with an obsolete attribute
Member
Author
There was a problem hiding this comment.
Should we error? o just warn?
|
|
||
| #if XAMCORE_4_0 | ||
| [DisableDefaultCtor] // [Assert] -init is not a useful initializer for this class. Use one of the designated initializers instead | ||
| #endif |
| #if XAMCORE_4_0 | ||
| [DisableDefaultCtor] // [Assert] -init is not a useful initializer for this class. Use one of the designated initializers instead | ||
| #endif | ||
| [NoWatch] |
Contributor
|
Build failure |
Member
Author
|
@spouliot Done! Thanks for the feedback! |
Contributor
|
Build failure |
rolfbjarne
requested changes
Jun 9, 2017
rolfbjarne
left a comment
rolfbjarne
left a comment
Member
There was a problem hiding this comment.
Also please add a bug for all the filter FIXMEs.
| namespace XamCore.Foundation { | ||
| #if !XAMCORE_4_0 | ||
| public partial class NSUnit { | ||
| [Obsolete ("Use the overload instead")] |
Removed XAMCORE_4_0 checks from our api definition, and added a file with stubs for all of them instead. Cleaner binding file and easier to remove in the future Fixed introspection also for mac by moving some check into base test definition
These need to be manually reviewed by whoever takes CoreImage framework tracked in bugzilla so we do not forget
… order to avoid linking symbols meeded by test (dotnet#2196) Rolf Kvinge [8:59 AM] @dalexsoto the fix is to not strip the executable please PR that (it should probably go into master as well). This probably started happening when Jeff implemented support for stripping debug builds (previously the setting was ignored)
dalexsoto
force-pushed
the
introspectionxcode9
branch
from
June 10, 2017 00:31
4362d75 to
ee3a64f
Compare
Member
Author
|
@rolfbjarne Fixed and bug filled here https://bugzilla.xamarin.com/show_bug.cgi?id=57350 also MtouchNoSymbolStrip fix is part of this PR |
Contributor
|
Build failure |
spouliot
approved these changes
Jun 10, 2017
Contributor
|
Build failure |
Contributor
|
Build failure |
Member
Author
|
Introspection is finally green 😀 |
rolfbjarne
approved these changes
Jun 10, 2017
dalexsoto
added a commit
that referenced
this pull request
Apr 2, 2020
New commits in xamarin/maccore: * xamarin/maccore@fdeec0f4cc Update external-deps.csx (#2191) * xamarin/maccore@f473e45166 [Localization] Rework mlaunch (#2171) Diff: https://github.com/xamarin/maccore/compare/5dbf6f4c5fdfd8fa24e569f89a7c79f12d99e9e5..fdeec0f4ccdfdb9111d594b7f7189cd58e06216d
dalexsoto
added a commit
that referenced
this pull request
Apr 2, 2020
New commits in xamarin/maccore: * xamarin/maccore@fdeec0f4cc Update external-deps.csx (#2191) * xamarin/maccore@f473e45166 [Localization] Rework mlaunch (#2171) Diff: https://github.com/xamarin/maccore/compare/5dbf6f4c5fdfd8fa24e569f89a7c79f12d99e9e5..fdeec0f4ccdfdb9111d594b7f7189cd58e06216d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug filled for AVPlayerLooper. LoopingEnabled -> https://bugzilla.xamarin.com/show_bug.cgi?id=57302
Bug filled for CoreImage filters -> https://bugzilla.xamarin.com/show_bug.cgi?id=57350
Need to radar