bump max visual studio version to latest alpha - #2171
Conversation
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
…eption while throwing an exception during a build.
|
You can see more about the issue that allow the bug to be seen here. https://bugzilla.xamarin.com/show_bug.cgi?id=57124 |
zippo227
changed the title
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
That needs to be 2 separate PR as they are unrelated changes, e.g. One might have to be reverted without the other
zippo227
changed the title
|
@spouliot I understand and changed as requested |
|
I think this got too bloated and it is not recognizing my rebase. I've made a new, cleaner pull request. #2173 |
New commits in xamarin/maccore: * xamarin/maccore@fdeec0f4cc Update external-deps.csx (#2191) * xamarin/maccore@f473e45166 [Localization] Rework mlaunch (#2171) Diff: https://github.com/xamarin/maccore/compare/5dbf6f4c5fdfd8fa24e569f89a7c79f12d99e9e5..fdeec0f4ccdfdb9111d594b7f7189cd58e06216d
New commits in xamarin/maccore: * xamarin/maccore@fdeec0f4cc Update external-deps.csx (#2191) * xamarin/maccore@f473e45166 [Localization] Rework mlaunch (#2171) Diff: https://github.com/xamarin/maccore/compare/5dbf6f4c5fdfd8fa24e569f89a7c79f12d99e9e5..fdeec0f4ccdfdb9111d594b7f7189cd58e06216d
The name of the dll changed, ergo the prefix changed. New commits in xamarin/maccore: * xamarin/maccore@a14f74b40a Revert "[Localization] Rework mlaunch (dotnet#2171)" (dotnet#2194) * xamarin/maccore@9939a3812d [mlaunch] Accept the latest C# language version in projects (dotnet#2193) Diff: https://github.com/xamarin/maccore/compare/fdeec0f4ccdfdb9111d594b7f7189cd58e06216d..a14f74b40ac5ed01a9a384d758b50e5a7c563569
New commits in xamarin/maccore: * xamarin/maccore@a14f74b40a Revert "[Localization] Rework mlaunch (dotnet#2171)" (dotnet#2194) * xamarin/maccore@9939a3812d [mlaunch] Accept the latest C# language version in projects (dotnet#2193) Diff: https://github.com/xamarin/maccore/compare/fdeec0f4ccdfdb9111d594b7f7189cd58e06216d..a14f74b40ac5ed01a9a384d758b50e5a7c563569
New commits in xamarin/maccore: * xamarin/maccore@a14f74b40a Revert "[Localization] Rework mlaunch (#2171)" (#2194) * xamarin/maccore@9939a3812d [mlaunch] Accept the latest C# language version in projects (#2193) Diff: https://github.com/xamarin/maccore/compare/fdeec0f4ccdfdb9111d594b7f7189cd58e06216d..a14f74b40ac5ed01a9a384d758b50e5a7c563569
4 participants
I increased the allowed visual studio version, and I added a fix that also prevents a null exception from attempting to be read during build error generation.