[maccore] Bump maccore to get AzDo script changes - #8269
Merged
Conversation
New commits in xamarin/maccore: * xamarin/maccore@fdeec0f4cc Update external-deps.csx (#2191) * xamarin/maccore@f473e45166 [Localization] Rework mlaunch (#2171) Diff: https://github.com/xamarin/maccore/compare/5dbf6f4c5fdfd8fa24e569f89a7c79f12d99e9e5..fdeec0f4ccdfdb9111d594b7f7189cd58e06216d
dalexsoto
added
pr-change-not-shipping
Contributor
|
Build success |
dalexsoto
added
the
trigger-device-tests
rolfbjarne
approved these changes
Apr 2, 2020
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.11', Running XM tests on '10.11'' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results145 tests failed, 40 tests passed.Failed tests
|
spouliot
approved these changes
Apr 2, 2020
Contributor
|
hmmm I don't like that harness exception |
Contributor
|
Added an issue for that xharness exception: #8271 |
mandel-macaque
approved these changes
Apr 2, 2020
Member
Author
|
Ok, PR looks good, mlaunch is used by our tests and seems to be fine, I'll address individual test reviews in the merged commit itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New commits in xamarin/maccore:
Diff: https://github.com/xamarin/maccore/compare/5dbf6f4c5fdfd8fa24e569f89a7c79f12d99e9e5..fdeec0f4ccdfdb9111d594b7f7189cd58e06216d
Needed by our internal build to pick Xcode 11.4.
Since this bump brings some Localization changes from maccore executing this on internal Jenkins
Also using this PR to check on sample tests, our AzDo pool got updated today!