feat(auth): Add support for FPNV #748
Conversation
- Release 4.12.0
This reverts commit 32af2b8.
* chore: Added and `AGENTS.md` file to instruct AI agents how to interact with this repository (firebase#710) * fix(auth): Fixed auth error code parsing (firebase#712) * fix(auth): Fixed auth error code parsing * fix(auth): Fixed test to use error message prefix * chore: update copyright headers from Google Inc. to Google LLC (firebase#713) * chore: Update github actions workflows and integration test resources (firebase#740) * chore: Pinned github actions to a full-length commit SHA * chore: Update integration test resources * chore: Added environment label to release action * Trigger integration tests * feat(firestore): Added Firestore Multi Database Support (firebase#733) * feat(firestore): Add Firestore Multi Database Support * fix: Address gemini review * fix: gemini review * fix: Update name from API review * fix: Address review comments * chore: Fix CONTRIBUTING.md typo Co-authored-by: Lahiru Maramba <llahiru@gmail.com> --------- Co-authored-by: Lahiru Maramba <llahiru@gmail.com> * feat(auth): Add `QueryUsers` API (firebase#727) This change implements the accounts:query functionality, providing a new QueryUsers method that allows searching for users with filters and sorting options. RELEASE_NOTE: Added QueryUsers() API to support querying user accounts with filters, sorting, and pagination. * Update the release actions process (firebase#741) This PR refactors the release automation to improve security by removing the direct merge from the workflow. * [chore] Release 4.19.0 (firebase#742) * Revert "[chore] Release 4.19.0 (firebase#742)" (firebase#744) This reverts commit 3a86709. * chore: Update Release Workflows for Push triggers (firebase#745) * chore: Update release actions to run on Release env * Trigger CI * update the actions * update the base_ref * remove fetch-depth to prevent conflicts * [chore] Release 4.19.0 Take 2 (firebase#746) --------- Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com> Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Summary of ChangesHello @boikoa-gl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request lays the groundwork for a new Go package, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Firebase Phone Number Verification (FPNV) by adding a new fpnv package and integrating it into the main firebase.App. The changes include the FPNV client implementation for verifying JWTs, along with corresponding tests.
My review focuses on the new fpnv package. I've identified a critical issue that could cause a panic when parsing the aud claim in a token, as well as another high-severity issue related to unsafe type assertions for other token claims. I've also included suggestions to improve test coverage and error handling consistency. Please address the potential panics to ensure the robustness of the new functionality.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for Firebase Phone Number Verification (FPNV). The changes include adding a new fpnv package for token verification, integrating it into the main firebase.App, and providing corresponding tests. The implementation of the token verification logic in fpnv/fpnv.go is mostly solid, but I've found a potential panic due to an unsafe type assertion and some redundant code that could be cleaned up. I've also spotted a minor typo in a comment. The tests are comprehensive and cover a good range of scenarios. Overall, this is a great addition.
3 participants
Added support for FPNV