Avoid showing the calltree panel in profiles without samples#4744
Merged
fqueze merged 1 commit intoSep 14, 2023
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4744 +/- ##
=======================================
Coverage 88.32% 88.33%
=======================================
Files 300 300
Lines 26733 26746 +13
Branches 7213 7217 +4
=======================================
+ Hits 23612 23625 +13
Misses 2908 2908
Partials 213 213
☔ View full report in Codecov by Sentry. |
canova
approved these changes
Sep 14, 2023
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Looks great to me, thanks for the fix!
| timelineType = determineTimelineType(profile); | ||
| } | ||
|
|
||
| let selectedTab = getSelectedTab(getState()); |
Member
There was a problem hiding this comment.
nit: Can we add a short code comment here maybe telling them that we are doing this for profiles without samples data.
fqueze
force-pushed
the
avoid-calltree-when-no-samples
branch
from
6e003ca to
6c21898
Compare
fqueze
force-pushed
the
avoid-calltree-when-no-samples
branch
from
6c21898 to
30cb840
Compare
tenderlove
added a commit
to tenderlove/profiler
that referenced
this pull request
Jan 16, 2024
* main: (37 commits) Show the hovered time in the ruler at the top of the timeline. (PR firefox-devtools#4748) Hardcode 'project' to 'firefox-profiler' in .taskcluster.yml (PR firefox-devtools#4759) Update all Yarn dependencies (2023-09-27) (PR firefox-devtools#4758) Update the uploading command in the developer documentation (PR firefox-devtools#4752) Make prettier ignore the taskcluster files Add taskcluster Update all Yarn dependencies (2023-09-20) (PR firefox-devtools#4756) Add a robots.txt file to disallow indexing our profile links (PR firefox-devtools#4753) Avoid showing the calltree panel in profiles without samples. (PR firefox-devtools#4744) Display the vertical line in the timeline when hovering the marker chart or stack chart (PR firefox-devtools#4742) Draw a single rectangle for 2 markers in bar charts only if both the start and end horizontal pixels match. (PR firefox-devtools#4734) Update all Yarn dependencies (2023-09-13) (firefox-devtools#4746) Update all Yarn dependencies (2023-09-06) (PR firefox-devtools#4741) Remove prefer-wait-for rule in our config because it's been removed from the plugin ⬆️ Update eslint-plugin-testing-library to version 6.0.1 Use a cache for prettier (PR firefox-devtools#4731) Remove leftover eslint error Run prettier on the codebase Upgrade prettier to latest version Ignore the coverage directory when present ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the "marker-chart" the default panel for profiles without samples. It also prevents from switching to the calltree panel when clicking the activity graph of a profile without samples (eg. where all samples are only "(root)").
Example of profile without samples to test with: https://profiler.firefox.com/public/w6a188gqfkm227vmvqgc69tj5edj49kqwyntefr/
Deploy preview: https://deploy-preview-4744--perf-html.netlify.app/public/w6a188gqfkm227vmvqgc69tj5edj49kqwyntefr/