Skip to content

Hardcode 'project' to 'firefox-profiler' in .taskcluster.yml#4759

Merged
julienw merged 1 commit into
firefox-devtools:mainfrom
ahal:taskcluster
Sep 27, 2023
Merged

Hardcode 'project' to 'firefox-profiler' in .taskcluster.yml#4759
julienw merged 1 commit into
firefox-devtools:mainfrom
ahal:taskcluster

Conversation

@ahal

@ahal ahal commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

We decided to use firefox-profiler as the project name in ci-config, which is different than the repo's actual name.

We decided to use `firefox-profiler` as the project name in ci-config,
which is different than the repo's actual name.
@ahal

ahal commented Sep 27, 2023

Copy link
Copy Markdown
Contributor Author

Alternatively we could change ci-config to use profiler as the project name. But..

  1. profiler is kind of generic, so it's not as obvious what the project is.
  2. I think there's value in having at least one project name not matching its repo name, so we can catch edge cases quicker while modifying ci-config

@julienw julienw merged commit ce71135 into firefox-devtools:main Sep 27, 2023
@ahal ahal deleted the taskcluster branch September 28, 2023 21:24
tenderlove added a commit to tenderlove/profiler that referenced this pull request Jan 16, 2024
* main: (37 commits)
  Show the hovered time in the ruler at the top of the timeline. (PR firefox-devtools#4748)
  Hardcode 'project' to 'firefox-profiler' in .taskcluster.yml (PR firefox-devtools#4759)
  Update all Yarn dependencies (2023-09-27) (PR firefox-devtools#4758)
  Update the uploading command in the developer documentation (PR firefox-devtools#4752)
  Make prettier ignore the taskcluster files
  Add taskcluster
  Update all Yarn dependencies (2023-09-20) (PR firefox-devtools#4756)
  Add a robots.txt file to disallow indexing our profile links (PR firefox-devtools#4753)
  Avoid showing the calltree panel in profiles without samples. (PR firefox-devtools#4744)
  Display the vertical line in the timeline when hovering the marker chart or stack chart (PR firefox-devtools#4742)
  Draw a single rectangle for 2 markers in bar charts only if both the start and end horizontal pixels match. (PR firefox-devtools#4734)
  Update all Yarn dependencies (2023-09-13) (firefox-devtools#4746)
  Update all Yarn dependencies (2023-09-06) (PR firefox-devtools#4741)
  Remove prefer-wait-for rule in our config because it's been removed from the plugin
  ⬆️ Update eslint-plugin-testing-library to version 6.0.1
  Use a cache for prettier (PR firefox-devtools#4731)
  Remove leftover eslint error
  Run prettier on the codebase
  Upgrade prettier to latest version
  Ignore the coverage directory when present
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants