feat: support from-url profiles in compare#4875
Merged
julienw merged 4 commits intoJan 19, 2024
Merged
Conversation
Support profiles with dataSource `from-url` in the comparison view. This change is simply applying the suggestion in firefox-devtools#3589 (comment) and removing the preceding check for dataSource being `public`, and running `yarn lint-fix`. It seems to work just fine for me when I run this project locally. I tested by pasting in two `https://profiler.firefox.com/from-url/https%253A%252F%252F` URLs that I had open in other browser tabs, and I get an apparently functioning comparison view. Closes firefox-devtools#3589
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4875 +/- ##
==========================================
- Coverage 88.41% 88.39% -0.03%
==========================================
Files 303 301 -2
Lines 27130 26901 -229
Branches 7329 7274 -55
==========================================
- Hits 23988 23779 -209
+ Misses 2924 2906 -18
+ Partials 218 216 -2 ☔ View full report in Codecov by Sentry. |
julienw
approved these changes
Jan 19, 2024
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks good to me!
Thanks also for the new test.
Merged
julienw
added a commit
that referenced
this pull request
Feb 6, 2024
[@canova Nazım Can Altınova] Return null instead of throwing an error if it fails to get the resource name in active tab view (#4905) [@fqueze Florian Quèze] Improve the precision of the getFittedText implementation. (#4893) [@fqueze Florian Quèze] Show marker count next to the marker name in the marker chart when a marker is hovered. (#4892) [@mstange Markus Stange] Convert some code to use the non-inverted call node table even while we're showing the inverted call tree (Merge PR #4899) [@canova Nazım Can Altınova] Bring the max stacking depth limit back for marker timings (#4898) [@mstange Markus Stange] Various preparations in call tree code for fast inverted tree (Merge PR #4897) [@mstange Markus Stange] Move call node path/index conversion functions into CallNodeInfo (Merge PR #4896) [@mstange Markus Stange] Make mergeFunction fast (Merge PR #4895) [@gthb Gunnlaugur Thor Briem] feat: support from-url profiles in compare (#4875) And all the locale contributors: de: Michael Köhler el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Fjoerfoks, Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Andreas Pettersson uk: Artem Polivanchuk zh-CN: 你我皆凡人, Olvcpr423, Pontoon zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Support profiles with
dataSourcefrom-urlin the comparison view.Closes #3589
How
Simply:
FR: Allow comparing non-public profiles #3589 (comment)
dataSourcebeingpublicyarn lint-fix.This seems to work just fine for me when I run this project locally. I tested by pasting in two
https://profiler.firefox.com/from-url/https%253A%252F%252FURLs that I had open in other browser tabs, and I get an apparently functioning comparison view.┆Issue is synchronized with this Jira Task