Deploy Feb 06, 2024#4910
Merged
Merged
Conversation
Support profiles with dataSource `from-url` in the comparison view. This change is simply applying the suggestion in #3589 (comment) and removing the preceding check for dataSource being `public`, and running `yarn lint-fix`. It seems to work just fine for me when I run this project locally. I tested by pasting in two `https://profiler.firefox.com/from-url/https%253A%252F%252F` URLs that I had open in other browser tabs, and I get an apparently functioning comparison view. Closes #3589
Co-authored-by: Francesco Lodolo [:flod] <flod+pontoon@mozilla.com>
…iler Co-authored-by: Pin-guang Chen <petercpg@mail.moztw.org>
Co-authored-by: Michael Köhler <michael.koehler1@gmx.de>
Co-authored-by: Valery Ledovskoy <valery@ledovskoy.com>
Co-authored-by: Andreas Pettersson <az@kth.se> Co-authored-by: Luna Jernberg <bittin@cafe8bitar.se>
Co-authored-by: Mark Heijl <markh@babelzilla.org>
Co-authored-by: Fjoerfoks <fryskefirefox@gmail.com>
…rofiler Co-authored-by: Marcelo Ghelman <marcelo.ghelman@gmail.com>
Co-authored-by: Fjoerfoks <fryskefirefox@gmail.com>
…ox Profiler Co-authored-by: Ian Neal <iann_bugzilla@blueyonder.co.uk>
Co-authored-by: Olvcpr423 <oliverchan86@outlook.com>
Co-authored-by: Jim Spentzos <jimspentzos2000@gmail.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: ravmn <ravmn@ravmn.cl>
Co-authored-by: Olvcpr423 <oliverchan86@outlook.com>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.2...3.1.3) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Wajsberg <felash@gmail.com>
Co-authored-by: Fjoerfoks <fryskefirefox@gmail.com>
Before: https://share.firefox.dev/3SbzpQy (1422 samples in mergeFunction) After: https://share.firefox.dev/3tVp3fQ (46 samples in mergeFunction, 30x faster)
This makes CallNodeInfo an interface, and puts the conversion functions between call node indexes and call node paths onto this new interface. It also provides accessor methods for the traditional members. This reduces the number of direct uses of the call node table. It will allow us to have two implementations in the future: One for the non-inverted call tree, and one for the inverted call tree.
Co-authored-by: Théo Chevalier <theochevalier@pm.me>
…guaranteed to have a non-inverted call node info. In these three functions we've already checked whether the CallNodeInfo is inverted. We only get here if it's the non-inverted CallNodeInfo. So getStackIndexToNonInvertedCallNodeIndex will return the same as getStackIndexToCallNodeIndex.
This replaces selectLeafCallNode and selectRootCallNode with a new action creater called selectSelfCallNode which handles both the inverted and the non-inverted case.
…we're showing the inverted call tree (Merge PR #4899)
Co-authored-by: Artem Polivanchuk <a.polivanchuk@outlook.com>
Co-authored-by: Melo46 <melo@carmu.com>
…marker is hovered. (#4892)
Co-authored-by: Melo46 <melo@carmu.com>
Co-authored-by: Olvcpr423 <oliverchan86@outlook.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: 你我皆凡人 <yuanbingyan@mail.ee> Co-authored-by: Olvcpr423 <oliverchan86@outlook.com>
…rce name in active tab view Previously if it was failing to find a resource name, it was throwing an error. This was happening because we are explicitly excluding the `about:blank` and `about:newtab` pages. They are excluded so we can find the correct page name.
For some reason we weren't printing the resource tracks. This wasn't great because it's important to see all the resources there to be able to test the active tab correctly.
This test is crashing when you revert the first commit. I had to change the setup function to make sure that it doesn't overwrite the profile.pages array that we overwritten already with a custom page url.
…rce name in active tab view (#4905)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[@canova Nazım Can Altınova] Return null instead of throwing an error if it fails to get the resource name in active tab view (#4905)
[@fqueze Florian Quèze] Improve the precision of the getFittedText implementation. (#4893)
[@fqueze Florian Quèze] Show marker count next to the marker name in the marker chart when a marker is hovered. (#4892)
[@mstange Markus Stange] Convert some code to use the non-inverted call node table even while we're showing the inverted call tree (Merge PR #4899)
[@canova Nazım Can Altınova] Bring the max stacking depth limit back for marker timings (#4898)
[@mstange Markus Stange] Various preparations in call tree code for fast inverted tree (Merge PR #4897)
[@mstange Markus Stange] Move call node path/index conversion functions into CallNodeInfo (Merge PR #4896)
[@mstange Markus Stange] Make mergeFunction fast (Merge PR #4895)
[@gthb Gunnlaugur Thor Briem] feat: support from-url profiles in compare (#4875)
And all the locale contributors:
de: Michael Köhler
el: Jim Spentzos
en-GB: Ian Neal
es-CL: ravmn
fr: Théo Chevalier
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Fjoerfoks, Mark Heijl
pt-BR: Marcelo Ghelman
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
uk: Artem Polivanchuk
zh-CN: 你我皆凡人, Olvcpr423, Pontoon
zh-TW: Pin-guang Chen