Return null instead of throwing an error if it fails to get the resource name in active tab view#4905
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4905 +/- ##
==========================================
+ Coverage 88.43% 88.46% +0.02%
==========================================
Files 304 304
Lines 27192 27207 +15
Branches 7329 7335 +6
==========================================
+ Hits 24047 24068 +21
+ Misses 2927 2923 -4
+ Partials 218 216 -2 ☔ View full report in Codecov by Sentry. |
canova
force-pushed
the
active-tab-no-innerwindowid
branch
2 times, most recently
from
ba5b1e5 to
2b78ee5
Compare
…rce name in active tab view Previously if it was failing to find a resource name, it was throwing an error. This was happening because we are explicitly excluding the `about:blank` and `about:newtab` pages. They are excluded so we can find the correct page name.
For some reason we weren't printing the resource tracks. This wasn't great because it's important to see all the resources there to be able to test the active tab correctly.
This test is crashing when you revert the first commit. I had to change the setup function to make sure that it doesn't overwrite the profile.pages array that we overwritten already with a custom page url.
canova
force-pushed
the
active-tab-no-innerwindowid
branch
from
2b78ee5 to
706ddfb
Compare
Merged
julienw
added a commit
that referenced
this pull request
Feb 6, 2024
[@canova Nazım Can Altınova] Return null instead of throwing an error if it fails to get the resource name in active tab view (#4905) [@fqueze Florian Quèze] Improve the precision of the getFittedText implementation. (#4893) [@fqueze Florian Quèze] Show marker count next to the marker name in the marker chart when a marker is hovered. (#4892) [@mstange Markus Stange] Convert some code to use the non-inverted call node table even while we're showing the inverted call tree (Merge PR #4899) [@canova Nazım Can Altınova] Bring the max stacking depth limit back for marker timings (#4898) [@mstange Markus Stange] Various preparations in call tree code for fast inverted tree (Merge PR #4897) [@mstange Markus Stange] Move call node path/index conversion functions into CallNodeInfo (Merge PR #4896) [@mstange Markus Stange] Make mergeFunction fast (Merge PR #4895) [@gthb Gunnlaugur Thor Briem] feat: support from-url profiles in compare (#4875) And all the locale contributors: de: Michael Köhler el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Fjoerfoks, Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Andreas Pettersson uk: Artem Polivanchuk zh-CN: 你我皆凡人, Olvcpr423, Pontoon zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4834.
Previously if it was failing to find a resource name, it was throwing an error. This was happening because we are explicitly excluding the
about:blankandabout:newtabpages. They are excluded so we can find the correct page name.Deploy previews:
Before / After
Before / After
┆Issue is synchronized with this Jira Task