[deploy preview] Add a tab selector#5068
Closed
canova wants to merge 14 commits into
Closed
Conversation
… it work on the full view Previously this function was only working on the active tab view. It made sense at the time, but not anymore since we would like to have the same logic in the full view and remove the active tab view altogether in the future.
This was referenced Aug 3, 2024
Contributor
|
The UI looks good to me! |
canova
added a commit
that referenced
this pull request
Aug 13, 2024
This is the second PR of #5068. It doesn't depend on the first PR, so you can review it independently. Also it's some refactoring and minor code changes without visible UI/UX changes. Previous and new tests should cover all the behaviors. Previously `extractProfileFilterPageData` was only working on the active tab view and was returning early for the full view, with this change it should be possible to run it in the full view as well. Similarly, I don't think it needs a deploy preview as it doesn't change anything, but let me know if you think otherwise.
canova
added a commit
that referenced
this pull request
Aug 20, 2024
This is the third PR of #5068. Previously we were only generating page information for the selected/active tab. But for the tab selector to work, we need page information of all tabs. So this PR makes sure that we extract the data for all of them. Again, this is not a user visible change.
canova
added a commit
that referenced
this pull request
Aug 21, 2024
…ant threads per tab (#5087) This is the fourth PR of #5068. This PR creates a `getTabToThreadIndexesMap` selector to be used in the next patches. It is useful to quickly get which tab uses which threads in the timeline, as well as gathering the CPU activity scores per tab to be able to sort the tab selector list. Also added some tests to check the behavior.
Member
Author
|
We have landed all the individual pieces and enabled the tab selector. Let's close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a tab selector on the top left corner, inside the "Full Range" breadcrumbs root. By clicking that, you can select a different tab and this will change the amount of global tracks and local tracks you'll get. Allowing web developers to see only the tracks that they are interested in. Note that this doesn't filter the samples or markers, it filters only the tracks.
There are few things I would like to fix still but I'm happy to get feedback on the UX and the UI. Please let me know what you think!
Deploy preview
cc @julienw @AdamBrouwersHarries @mstange @fqueze