[Tab selector #1] Add a redux state for the tab filter#5072
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
=======================================
Coverage 88.48% 88.49%
=======================================
Files 304 304
Lines 27444 27461 +17
Branches 7423 7430 +7
=======================================
+ Hits 24285 24302 +17
Misses 2934 2934
Partials 225 225 ☔ View full report in Codecov by Sentry. |
canova
force-pushed
the
tab-selector-redux-state
branch
3 times, most recently
from
75f1cfe to
d85fe73
Compare
julienw
approved these changes
Aug 5, 2024
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
It looks reasonable to me, thanks
| urlState.profileSpecific.full.localTrackOrderByPid, | ||
| urlState.profileSpecific.full.localTrackOrderChangedPids | ||
| ); | ||
| baseQuery.tabID = urlState.profileSpecific.full.tabFilter || undefined; |
Contributor
There was a problem hiding this comment.
I'd do:
Suggested change
| baseQuery.tabID = urlState.profileSpecific.full.tabFilter || undefined; | |
| baseQuery.tabID = urlState.profileSpecific.full.tabFilter ?? undefined; |
because tabFilter is a number and could be theorically 0
Member
Author
There was a problem hiding this comment.
Good catch, changed it. Thanks!
Comment on lines
+586
to
+591
| let oldTabID = null; | ||
| if (query.ctxId && Number.isInteger(Number(query.ctxId))) { | ||
| tabID = Number(query.ctxId); | ||
| oldTabID = Number(query.ctxId); | ||
| } |
Contributor
There was a problem hiding this comment.
a comment to explain the difference between both tab ids could be useful
Member
Author
There was a problem hiding this comment.
Yeah, added one. I will remove this in the end but still keeping while we have the active tab view. But I'm thinking about at which point I should remove the old active tab view. Maybe it's better to do it sooner than later.
canova
force-pushed
the
tab-selector-redux-state
branch
from
d85fe73 to
5968863
Compare
Member
Author
|
Thanks for the review! |
Merged
canova
added a commit
that referenced
this pull request
Sep 5, 2024
[Tatsuyuki Ish] Fix type error in getPagesMap (#5063) [Nazım Can Altınova] [Tab selector 1] Add a redux state for the tab filter (#5072) [Markus Stange] Remove a test for the inverted stack chart. (#5075) [Markus Stange] Add an inverted tree test for getSamplesSelectedStates and getTreeOrderComparator (#5076) [Nazım Can Altınova] [Tab selector 2] Extract the page data in the full view (#5073) [Nazım Can Altınova] Do not crash on timeline hover/selection when a profile doesn't have any samples or markers (#5086) [Nazım Can Altınova] [Tab selector 3] Generate page information for all tabs (#5082) [Nazım Can Altınova] [Tab selector 4] Add a getTabToThreadIndexesMap selector to get relevant threads per tab (#5087) [joshuaobrien] Use the word 'archive' instead of 'zip file' in copy (#5081) [Markus Stange] Send a UserAgent header to the symbolication server again (#5103) [Julien Wajsberg] Add some console utilities to retrieve the current profile and save it to disk (#5105) [Nazım Can Altınova] Add `selectedMarker` to the console APIs (#5107) And various dependency updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR from #5068.
It adds the basic redux state and adds some tests for this behavior. It doesn't change anything related to user visible behavior yet.
I don't think it needs a deploy preview as it doesn't change anything, but let me know if you think otherwise.