[Tab selector #2] Extract the page data in the full view#5073
Merged
Conversation
canova
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5073 +/- ##
==========================================
- Coverage 88.49% 88.49% -0.01%
==========================================
Files 304 304
Lines 27461 27463 +2
Branches 7430 7430
==========================================
+ Hits 24302 24303 +1
- Misses 2934 2935 +1
Partials 225 225 ☔ View full report in Codecov by Sentry. |
julienw
approved these changes
Aug 9, 2024
| } | ||
|
|
||
| const pageUrl = filteredPages[0].url; | ||
| const pageUrl = filteredPages[filteredPages.length - 1].url; |
Contributor
There was a problem hiding this comment.
too bad flow doesn't support .at(-1) 😅
| return item; | ||
| }; | ||
|
|
||
| const topMostParent = getTopMostParent(page); |
Contributor
There was a problem hiding this comment.
I do find it easier to understand, thanks
… it work on the full view Previously this function was only working on the active tab view. It made sense at the time, but not anymore since we would like to have the same logic in the full view and remove the active tab view altogether in the future.
This doesn't change the behavior, but makes it easier to read and understand.
Member
Author
|
Thanks for the review! |
Merged
canova
added a commit
that referenced
this pull request
Sep 5, 2024
[Tatsuyuki Ish] Fix type error in getPagesMap (#5063) [Nazım Can Altınova] [Tab selector 1] Add a redux state for the tab filter (#5072) [Markus Stange] Remove a test for the inverted stack chart. (#5075) [Markus Stange] Add an inverted tree test for getSamplesSelectedStates and getTreeOrderComparator (#5076) [Nazım Can Altınova] [Tab selector 2] Extract the page data in the full view (#5073) [Nazım Can Altınova] Do not crash on timeline hover/selection when a profile doesn't have any samples or markers (#5086) [Nazım Can Altınova] [Tab selector 3] Generate page information for all tabs (#5082) [Nazım Can Altınova] [Tab selector 4] Add a getTabToThreadIndexesMap selector to get relevant threads per tab (#5087) [joshuaobrien] Use the word 'archive' instead of 'zip file' in copy (#5081) [Markus Stange] Send a UserAgent header to the symbolication server again (#5103) [Julien Wajsberg] Add some console utilities to retrieve the current profile and save it to disk (#5105) [Nazım Can Altınova] Add `selectedMarker` to the console APIs (#5107) And various dependency updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second PR of #5068.
It doesn't depend on the first PR, so you can review it independently. Also it's some refactoring and minor code changes without visible UI/UX changes. Previous and new tests should cover all the behaviors.
Previously
extractProfileFilterPageDatawas only working on the active tab view and was returning early for the full view, with this change it should be possible to run it in the full view as well.Similarly, I don't think it needs a deploy preview as it doesn't change anything, but let me know if you think otherwise.