Speed up createCallNodeTable by 2.3x#5248
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5248 +/- ##
=======================================
Coverage 85.96% 85.97%
=======================================
Files 312 312
Lines 30331 30357 +26
Branches 8295 8296 +1
=======================================
+ Hits 26073 26098 +25
- Misses 3661 3662 +1
Partials 597 597 ☔ View full report in Codecov by Sentry. |
mstange
changed the title
mstange
force-pushed
the
push-zxksrqmzrrvw
branch
from
f7534bc to
4104ce1
Compare
mstange
force-pushed
the
push-zxksrqmzrrvw
branch
from
4104ce1 to
208376b
Compare
|
Flagging nazim because I'll be PTO the next few days. But I can look at it when I come back. |
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me!
| const funcIndex = frameTableFuncCol[frameIndex]; | ||
| funcCol[callNodeIndex] = funcIndex; |
There was a problem hiding this comment.
super nit: I'd group these into just one line and remove the funcIndex constant. As it is written now, it looks like we'll reuse funcIndex later (but we don't).
|
|
||
| const innerWindowID = frameTableInnerWindowIDCol[frameIndex]; | ||
| if (innerWindowID !== null) { | ||
| innerWindowIDCol[callNodeIndex] = innerWindowID; |
There was a problem hiding this comment.
nit: what do you think about adding a comment reminding that the TypedArray is initialized with "0"?
| hierarchy; | ||
|
|
||
| if (length === 0) { | ||
| throw new Error('Empty call node table hierarchy'); |
There was a problem hiding this comment.
I'm a bit worried by this throw. Would it be possible to return something sensible instead?
There was a problem hiding this comment.
Ok, replaced this with a return.
…umns until we know the final size and order of the call node table.
mstange
force-pushed
the
push-zxksrqmzrrvw
branch
from
05d9963 to
c64b01b
Compare
[Julien Wajsberg] Update node to v22 (#5378) [Markus Stange] Speed up createCallNodeTable by 2.3x (#5248) [Markus Stange] Remove frameTable.implementation from the processed format. (#5370) [Florian Quèze] Show size units in the timeline for profiles where profile.meta.sampleUnits.time is "bytes". (#5364) [Sean Kim] Report nsIRequest::status (nsresult) in the marker (#5375) [Markus Stange] Change the marker schema to accept a description and get rid of the notion of static fields (#5385) Also thanks to our localizers: en-CA: Paul tr: Grk
2 participants
Production | Deploy preview
Built on top of #4900, but the only real dependency is on the changeset that makes the
inlinedIntocolumn a typed array.Before: https://share.firefox.dev/4fX1MwP (1884 samples in
CakacomputeCallNodeTable)After: https://share.firefox.dev/4gjkTAT (804 samples in
CakacomputeCallNodeTable, 2.3x faster)Main unminified: https://share.firefox.dev/4fkDOdP
After #4900 unminified: https://share.firefox.dev/4g0ujS7
After #5248 unminified: https://share.firefox.dev/41kpGhe