Update node to v22#5378
Conversation
julienw
force-pushed
the
update-node-v22
branch
2 times, most recently
from
a5005b2 to
584616d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5378 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 312 312
Lines 30330 30330
Branches 8296 8296
=======================================
Hits 26074 26074
Misses 3659 3659
Partials 597 597 ☔ View full report in Codecov by Sentry. |
| @@ -1 +1 @@ | |||
| 18.19 | |||
| 22 | |||
There was a problem hiding this comment.
Should we also put 22.14 here specifically?
There was a problem hiding this comment.
This question sparked a lot of conflicting thoughts :-D
- Initially I was thinking that nvm would install the latest version which will always be >= 22.14, but if the user already has an earlier v22 it would indeed fail later.
- Then I tried locally:
nvm usedoesn't install it automatically, it only tries to use it if available. So in that case leaving it at22would probably be better. For example that would let a user pick a later version too. - However I believe we don't use
nvm useourselves without a version number, we mostly use a version number explicitely. So this.nvmrcis more a hint to a user. But, more importantly, it is used by netlify to pick a node version (netlify will install it if it's not present).
Looking at the history of .nvmrc, I'm gonna use the more explicit version name like you suggested. This way we control the node version we know it's working for generating the project.
There was a problem hiding this comment.
I wonder if I should use 22.14 also in package.json, given this is the version checked by bin/pre-install.js... what do you think?
Or maybe we can remove it from pre-install.js at all, if this is checked by yarn directly now?
There was a problem hiding this comment.
We can do that as a follow-up, I'm gonna merge this for now :-)
julienw
force-pushed
the
update-node-v22
branch
from
584616d to
f4ca4b1
Compare
[Julien Wajsberg] Update node to v22 (#5378) [Markus Stange] Speed up createCallNodeTable by 2.3x (#5248) [Markus Stange] Remove frameTable.implementation from the processed format. (#5370) [Florian Quèze] Show size units in the timeline for profiles where profile.meta.sampleUnits.time is "bytes". (#5364) [Sean Kim] Report nsIRequest::status (nsresult) in the marker (#5375) [Markus Stange] Change the marker schema to accept a description and get rid of the notion of static fields (#5385) Also thanks to our localizers: en-CA: Paul tr: Grk
2 participants
This updates node to version 22. This only needed very few changes in the tests.