Show size units in the timeline for size profiles

[fqueze]

Example profile: https://share.firefox.dev/42Kf0Ju

[codecov]

Codecov Report

Attention: Patch coverage is 97.05882% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (7f30744) to head (2caf554).
Report is 91 commits behind head on main.

Files with missing lines	Patch %	Lines
src/components/timeline/Ruler.js	83.33%	2 Missing ⚠️
src/profile-logic/committed-ranges.js	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5364      +/-   ##
==========================================
+ Coverage   85.84%   85.90%   +0.06%     
==========================================
  Files         312      312              
  Lines       29827    29893      +66     
  Branches     8213     8245      +32     
==========================================
+ Hits        25605    25680      +75     
+ Misses       3627     3621       -6     
+ Partials      595      592       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mstange]

I think this is cool idea. But I think it shouldn't be magically based on threads[0].samples.weightType - it's something that affects all threads and it should be explicitly set in the profile, for example inside profile.meta.

[mstange]

Functionality looks good, all my change requests are about types, function names and tests.

[mstange]

(no action needed:) It's interesting to me that format-numbers.js is tested via the marker schema. It would make more sense to me to have these tests in format-numbers.test.js but I guess you're just following what's already there.

[mstange]

Looks good to me!

I should acknowledge that it's going to be confusing to have many variables with time or Milliseconds in them which can now store values in bytes. Can you file a follow-up issue to find a way to clean this up (for example by renaming time to offset)?

[julienw]

looks like this was forgotten:

profiler/src/components/stack-chart/Canvas.js

Line 487 in 90bb6f3

durationText={formatMilliseconds(duration)}