Allow searching by Content-Type in the network marker view

[padenot]

Production / Deploy preview

[canova]

Thanks for the patch, there were some zero width spaces for some reason in the changes and that made all the CI fail. Also I applied the formatting changes.

Unfortunately tests are still failing. Apparently this change made it appear the content type twice in the tooltip. Here are some pics:
Before:

After:

Notice the new "Content type" at the top in addition to "MIME type".
So unfortunately this PR needs some more changes to hide it in the tooltip and make sure that only one of them is visible.

This is the place we append the network maker details to the tooltip:

profiler/src/components/tooltip/Marker.js

Lines 304 to 308 in b5ea860

	case 'Network': {
	// Network markers embed lots of timing information inside of them, that
	// must be reworked in the tooltip.
	details.push(...getNetworkMarkerDetails(data));
	break;

And this is the place we add the data fields that are inside the schema:

profiler/src/components/tooltip/Marker.js

Lines 252 to 269 in b5ea860

	// Don't add undefined values, as values are optional.
	if (value !== undefined && value !== null) {
	details.push(
	<TooltipDetail
	key={schema.name + '-' + key}
	label={label || key}
	>
	{formatMarkupFromMarkerSchema(
	schema.name,
	format,
	value,
	thread.stringTable,
	threadIdToNameMap,
	processIdToNameMap
	)}
	</TooltipDetail>
	);
	}

So we would need to either clear the details for the network markers in here, or we need to have a field in the schema to indicate that a field is hidden. Markus recently filed a bug about this already: #5299

@padenot So probably this is more work than you initially intended. Would you want to work on it or would you want to let us handle the rest?

[canova]

We can add hidden: true field after #5354 lands to make this work and land.

[canova]

Hey @julienw, I've changed the code slightly after landed #5354. It would be good if you can review it.

redirecting

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (3f80e20) to head (baea128).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5351   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files         312      312           
  Lines       29829    29829           
  Branches     8214     8214           
=======================================
  Hits        25607    25607           
  Misses       3627     3627           
  Partials      595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[julienw]

looks good to me!
do you think you could add a quick test to src/test/components/NetworkChart.test.js?

[canova]

Thanks for the review!

looks good to me! do you think you could add a quick test to src/test/components/NetworkChart.test.js?

Hm, I don't necessarily think that this needs extra testing. This field is essentially the combination of two things: searchable and hidden fields. And we have individual tests for both of them already.