Add the ability to mark marker fields as hidden#5354
Merged
Conversation
canova
force-pushed
the
marker-hidden-fields
branch
from
3afe244 to
e59525d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5354 +/- ##
==========================================
- Coverage 85.84% 85.84% -0.01%
==========================================
Files 312 312
Lines 29827 29829 +2
Branches 8213 8214 +1
==========================================
+ Hits 25605 25606 +1
- Misses 3627 3628 +1
Partials 595 595 ☔ View full report in Codecov by Sentry. |
canova
force-pushed
the
marker-hidden-fields
branch
from
e59525d to
220ae3c
Compare
mstange
reviewed
Feb 10, 2025
mstange
approved these changes
Feb 10, 2025
mstange
left a comment
mstange
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks! Just one comment about the comment.
canova
force-pushed
the
marker-hidden-fields
branch
from
220ae3c to
ac52040
Compare
Member
Author
|
Thanks for the review! |
Merged
canova
added a commit
that referenced
this pull request
Feb 19, 2025
## Updates: [Nicolas Chevobbe] Make timeline ruler notches visible in High Contrast Mode (#5346) [Nazım Can Altınova] Add the ability to mark marker fields as hidden (#5354) [Maxx Crawford] Update guide-startup-shutdown.md (#5357) [Nazım Can Altınova] Enable prettier on the docs-user markdown files (#5358) [Paul Adenot] Allow searching by Content-Type in the network marker view (#5351) [Florian Quèze] Hide the pid in global tracks if it is 0. (#5361) [Markus Stange] Make inverting the call tree fast, by computing inverted call nodes lazily (#4900) [Markus Stange] Use 64-bit floats for call tree timings. (#5371) [Markus Stange] Extend the workaround in the v53 upgrader to generate missing subcategory columns. (#5369) ## Also thanks to our localizers: de: Michael Köhler el: Jim Spentzos en-GB: Paul es-CL: ravmn fr: Théo Chevalier fur: Fabio Tomat fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Luna Jernberg, Andreas Pettersson tr: Grk uk: Іhor Hordiichuk zh-CN: Olvcpr423 zh-TW: Pin-guang Chen
mstange
added a commit
to mstange/perf.html
that referenced
this pull request
Feb 25, 2025
…tools#5364 in the upgrader and changelog for version 54.
mstange
added a commit
to mstange/perf.html
that referenced
this pull request
Feb 25, 2025
…tools#5364 in the upgrader and changelog for version 54.
julienw
pushed a commit
that referenced
this pull request
Feb 26, 2025
…hangelog for version 54. (#5384)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5299
It was quite easy to add, simply it adds a new optional field called
hidden. If it's true we don't show it in the marker tooltip or sidebar.(For deploy preview, currently there is no marker that uses it, so nothing to see really)