Enable prettier on the docs-user markdown files#5358
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5358 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 312 312
Lines 29829 29829
Branches 8214 8214
=======================================
Hits 25607 25607
Misses 3627 3627
Partials 595 595 ☔ View full report in Codecov by Sentry. |
julienw
approved these changes
Feb 7, 2025
Member
Author
|
Yeah, I will land the other one first. |
Previously prettier was disabled on every file inside `docs-user/`. With this patch, we are only limiting the prettierignore to the js and css files inside that directory and not the markdown files. This also required me to reformat pretty much the whole directory.
canova
force-pushed
the
docs-user-prettier
branch
from
ad23d45 to
7cf4f90
Compare
Member
Author
|
Landed #5357 and rebased this on top of it. Landing this one too. |
Merged
canova
added a commit
that referenced
this pull request
Feb 19, 2025
## Updates: [Nicolas Chevobbe] Make timeline ruler notches visible in High Contrast Mode (#5346) [Nazım Can Altınova] Add the ability to mark marker fields as hidden (#5354) [Maxx Crawford] Update guide-startup-shutdown.md (#5357) [Nazım Can Altınova] Enable prettier on the docs-user markdown files (#5358) [Paul Adenot] Allow searching by Content-Type in the network marker view (#5351) [Florian Quèze] Hide the pid in global tracks if it is 0. (#5361) [Markus Stange] Make inverting the call tree fast, by computing inverted call nodes lazily (#4900) [Markus Stange] Use 64-bit floats for call tree timings. (#5371) [Markus Stange] Extend the workaround in the v53 upgrader to generate missing subcategory columns. (#5369) ## Also thanks to our localizers: de: Michael Köhler el: Jim Spentzos en-GB: Paul es-CL: ravmn fr: Théo Chevalier fur: Fabio Tomat fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Luna Jernberg, Andreas Pettersson tr: Grk uk: Іhor Hordiichuk zh-CN: Olvcpr423 zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously prettier was disabled on every file inside
docs-user/. With this patch, we are only limiting the prettierignore to the js and css files inside that directory and not the markdown files.This also required me to reformat pretty much the whole directory.