Rework (and rename) ext event#1401
Conversation
|
I decided to rename form |
druid/examples/async_event.rs
Outdated
| use druid::widget::prelude::*; | ||
| use druid::{AppLauncher, Color, Selector, Target, WidgetExt, WindowDesc}; | ||
|
|
||
| // If you want to send commands to over event sinks you have to give it some kind |
There was a problem hiding this comment.
commands to over event sinks not sure what you're saying here
There was a problem hiding this comment.
If you want to submit commands to an event sink is what I mean
futurepaul
left a comment
futurepaul
left a comment
There was a problem hiding this comment.
This is a great improvement! I'm fine with the name change. I could see people being confused that this isn't async in the general Rust ecosystem use of that word, but at the same time that's probably the word people are looking for for this kind of functionality?
|
yeah I thought about that too, I can rename it to |
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Looks good, a few little notes but I think this is an improvement!
druid/examples/async_event.rs
Outdated
| .expect("launch failed"); | ||
| } | ||
|
|
||
| fn generate_colours(event_sink: druid::ExtEventSink) { |
There was a problem hiding this comment.
Although I personally use international spellings frequently, we have decided to use Color instead of Colour in druid so I think it probably makes sense to be consistent with that here as well?
There was a problem hiding this comment.
oh sry, I try to keep is US English as well, but my nature is very much still with colour.
There was a problem hiding this comment.
me too, but sometimes we must defer to the imperialists. 😢
Co-authored-by: Colin Rofls <colin@cmyr.net>
3 participants
This mostly just adds comments.
I also got a more satisfying colour generation comming in another PR for this and the
identityexample.I also think that this and the
identityone are too similair to not be based on each other. Both use comands and have colours shifting going on. Both should handle the colour shifting the same way (not using timers like theidentityexample) so I will be opening a PR about completely redoing that one. It will also make it cleaner I think.EDIT: I also will be opening a PR to remove the
blocking_functionsexample since it really just has a lot of clutter and revolves around the same concept as this example.sorry this took a while, my factorio addiction is acting up again.