Skip to content

MSC3989: Redact origin property on events #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turt2live merged 7 commits into from
Jun 19, 2023
Merged

MSC3989: Redact origin property on events #3989

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8173509
Redact `origin` field on events
turt2live Apr 4, 2023
84051f2
Merge branch 'main' into travis/msc/redact-origin-field
turt2live May 24, 2023
5ce2eec
Provide context and remove hunt for more useless fields
turt2live May 24, 2023
056bdb1
spelling: actually
turt2live May 24, 2023
6317497
Apply suggestions from code review
turt2live May 31, 2023
e47ec7f
Slight wording alterations
turt2live May 31, 2023
1f44feb
Property
turt2live May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spelling: actually
  • Loading branch information
@turt2live
turt2live committed May 24, 2023
commit 056bdb10ae73b83ab8e1146168ca3f35166440a4
2 changes: 1 addition & 1 deletion proposals/3989-redact-origin-field.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ and have [tried to do so](https://github.com/matrix-org/matrix-spec/pull/998) in
malformed examples are even [known to us](https://github.com/matrix-org/matrix-spec/issues/1480).

What's not clear, and mentioned in [a comment](https://github.com/matrix-org/matrix-spec/issues/1480#issuecomment-1495183789),
is whether the `origin` field is *acutally* used. There do not appear to be any auth rules or similar
is whether the `origin` field is *actually* used. There do not appear to be any auth rules or similar
which would use the field, however it'd hardly be the first time that the spec was wrong about an
ancient room version like v1. What is clear is that Synapse, where this question would be asked,
wants to [drop support](https://github.com/matrix-org/synapse/issues/3816) for the field and has
Expand Down