Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
  • Loading branch information
turt2live and richvdh authored May 31, 2023
commit 6317497c07e95af83ef4b7f71fd4ca90ea36ffcc
8 changes: 4 additions & 4 deletions proposals/3989-redact-origin-field.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# MSC3989: Redact `origin` field on events

The [current redaction algorithm](https://spec.matrix.org/v1.6/rooms/v10/#redactions) *keeps* the
top-level `origin` field on events during redaction, however the only use of it within the spec
as of writing is a malformed example of event format. The field has no significant meaning in
modern room versions.
top-level `origin` property on events during redaction, however, as of this writing, the only use within the
spec of `origin` as a top-level event property is a malformed example of event format. The field has no
significant meaning in modern room versions.

Within the ecosystem, it's clear that we'd [prefer the field to disappear](https://github.com/matrix-org/matrix-spec/issues/374),
and have [tried to do so](https://github.com/matrix-org/matrix-spec/pull/998) in the past. The
Expand All @@ -18,7 +18,7 @@ taken [steps](https://github.com/matrix-org/synapse/pull/8324) towards that miss
in the area. In a [quick audit](https://github.com/matrix-org/matrix-spec-proposals/pull/3989#issuecomment-1497659507)
of the Synapse codebase during implementation of this MSC, the `origin` field appears unused.

Given the above context, this proposal removes the `origin` field from the redaction algorithm in
Given the above context, this proposal removes the `origin` field from the [redaction algorithm](https://spec.matrix.org/v1.7/rooms/v10/#redactions) in
future room versions, leaving it as-is for existing versions (not that an MSC can change the behaviour
of an already-stable room version).

Expand Down