Skip to content

MSC3989: Redact origin property on events #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turt2live merged 7 commits into from
Jun 19, 2023
Merged

MSC3989: Redact origin property on events #3989

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8173509
Redact `origin` field on events
turt2live Apr 4, 2023
84051f2
Merge branch 'main' into travis/msc/redact-origin-field
turt2live May 24, 2023
5ce2eec
Provide context and remove hunt for more useless fields
turt2live May 24, 2023
056bdb1
spelling: actually
turt2live May 24, 2023
6317497
Apply suggestions from code review
turt2live May 31, 2023
e47ec7f
Slight wording alterations
turt2live May 31, 2023
1f44feb
Property
turt2live May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Slight wording alterations
  • Loading branch information
@turt2live
turt2live committed May 31, 2023
commit e47ec7f34a1fa6fa1796db5f85223fb54342535f
10 changes: 5 additions & 5 deletions proposals/3989-redact-origin-field.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# MSC3989: Redact `origin` field on events

The [current redaction algorithm](https://spec.matrix.org/v1.6/rooms/v10/#redactions) *keeps* the
top-level `origin` property on events during redaction, however, as of this writing, the only use within the
spec of `origin` as a top-level event property is a malformed example of event format. The field has no
top-level `origin` property on events during redaction, however, as of this writing, the only use within the
spec of `origin` as a top-level event property is a malformed example of event format. The field has no
significant meaning in modern room versions.

Within the ecosystem, it's clear that we'd [prefer the field to disappear](https://github.com/matrix-org/matrix-spec/issues/374),
Expand All @@ -18,9 +18,9 @@ taken [steps](https://github.com/matrix-org/synapse/pull/8324) towards that miss
in the area. In a [quick audit](https://github.com/matrix-org/matrix-spec-proposals/pull/3989#issuecomment-1497659507)
of the Synapse codebase during implementation of this MSC, the `origin` field appears unused.

Given the above context, this proposal removes the `origin` field from the [redaction algorithm](https://spec.matrix.org/v1.7/rooms/v10/#redactions) in
future room versions, leaving it as-is for existing versions (not that an MSC can change the behaviour
of an already-stable room version).
Given the above context, this proposal removes the `origin` field from the [redaction algorithm](https://spec.matrix.org/v1.7/rooms/v10/#redactions)
in a future room version, leaving it as-is for existing versions (not that an MSC can change the behaviour
of an already-stable room version anyways).

Some other fields are additionally useless in modern room versions, however they are already adapted
by [MSC2176](https://github.com/matrix-org/matrix-spec-proposals/pull/2176).
Expand Down