Skip to content

Component Template: Remove className export #24045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behowell merged 3 commits into from
Jul 28, 2022
Merged

Component Template: Remove className export #24045

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfdc3c9
Remove className export from component template
behowell Jul 22, 2022
8579643
Merge branch 'microsoft:master' into template/remove-classname-export
behowell Jul 25, 2022
5695e51
Merge branch 'microsoft:master' into template/remove-classname-export
behowell Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...mponent/plop-templates/src/components/{{componentName}}/use{{componentName}}Styles.ts.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import type { {{componentName}}Slots, {{componentName}}State } from './{{compone
import type { SlotClassNames } from '@fluentui/react-utilities';


export const {{componentNames.propertyName}}ClassName = 'fui-{{componentName}}'

@ling1726 ling1726 Jul 25, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the conformance tests so that this does not fail for folks creating new packages

fluentui/packages/react-conformance/src/defaultTests.tsx

Line 294 in 7878a9b

expect(indexFile[exportName]).toBe(componentClassName);

@sopranopillow sopranopillow Jul 25, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomi-msft just picked up the issue to remove the tests 😁

@behowell behowell Jul 26, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for @tomi-msft's PR to be merged before merging this one:

@behowell behowell Jul 27, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ling1726 The PR to remove the test is now merged

export const {{componentNames.propertyName}}ClassNames:SlotClassNames<{{componentName}}Slots> = {
root: 'fui-{{componentName}}'
// TODO: add class names for all slots on {{componentName}}Slots.
Expand Down