fix: Autofill queries the inputElement ownerDocument instead of document by smhigley · Pull Request #27312 · microsoft/fluentui

smhigley · 2023-03-23T17:46:38Z

Previous Behavior

Autofill compared this._inputElement.current === document.activeElement, which was causing issues when used in a child window.

New Behavior

Autofill uses getDocument(this._inputElement.current)

Related Issue(s)

Fixes [Bug]: Auto complete of AppComboBox is not behaving correctly in popout window #27099

codesandbox-ci · 2023-03-23T17:58:07Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d9eb80:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2023-03-23T18:01:20Z

Asset size changes

Project	Bundle	Baseline Size	New Size	Difference
office-ui-fabric-react	fluentui-react-Autofill	14.994 kB	15.334 kB	340 bytes
office-ui-fabric-react	fluentui-react-ExtendedPicker	94.558 kB	94.757 kB	199 bytes
office-ui-fabric-react	fluentui-react-ComboBox	242.201 kB	242.348 kB	147 bytes
office-ui-fabric-react	fluentui-react-TimePicker	232.425 kB	232.57 kB	145 bytes
office-ui-fabric-react	fluentui-react-Pickers	284.734 kB	284.865 kB	131 bytes

Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B

Baseline commit: 4a548bb4b188c50e782e134e447d8b06867a3c6f (build)

fabricteam · 2023-03-23T18:01:55Z

📊 Bundle size report

_{🤖 This report was generated against 4a548bb4b188c50e782e134e447d8b06867a3c6f}

fabricteam · 2023-03-23T18:02:35Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	888	880	5000
Button	mount	590	598	5000
Field	mount	1538	1514	5000
FluentProvider	mount	1095	1102	5000
FluentProviderWithTheme	mount	286	300	10
FluentProviderWithTheme	virtual-rerender	283	292	10
FluentProviderWithTheme	virtual-rerender-with-unmount	299	293	10
InfoButton	mount	205	200	5000
MakeStyles	mount	1411	1420	50000
Persona	mount	2163	2069	5000
SpinButton	mount	1838	1873	5000

fabricteam · 2023-03-23T18:07:39Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-03-23T18:17:25Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	593	625	5000
Breadcrumb	mount	1663	1640	1000
Checkbox	mount	1671	1692	5000
CheckboxBase	mount	1462	1484	5000
ChoiceGroup	mount	2930	2938	5000
ComboBox	mount	645	673	1000
CommandBar	mount	6093	6143	1000
ContextualMenu	mount	11725	12353	1000
DefaultButton	mount	743	725	5000
DetailsRow	mount	2213	2151	5000
DetailsRowFast	mount	2189	2119	5000
DetailsRowNoStyles	mount	1985	2005	5000
Dialog	mount	2582	2661	1000
DocumentCardTitle	mount	216	217	1000
Dropdown	mount	1944	1962	5000
FocusTrapZone	mount	1129	1136	5000
FocusZone	mount	1088	1078	5000
GroupedList	mount	40598	40492	2
GroupedList	virtual-rerender	19457	19466	2
GroupedList	virtual-rerender-with-unmount	49926	50201	2
GroupedListV2	mount	220	217	2
GroupedListV2	virtual-rerender	205	207	2
GroupedListV2	virtual-rerender-with-unmount	227	214	2
IconButton	mount	1065	1043	5000
Label	mount	326	336	5000
Layer	mount	2658	2679	5000
Link	mount	387	383	5000
MenuButton	mount	935	924	5000
MessageBar	mount	21410	21308	5000
Nav	mount	1913	1901	1000
OverflowSet	mount	758	767	5000
Panel	mount	1748	1761	1000
Persona	mount	730	738	1000
Pivot	mount	856	845	1000
PrimaryButton	mount	839	829	5000
Rating	mount	4539	4560	5000
SearchBox	mount	892	880	5000
Shimmer	mount	1894	1826	5000
Slider	mount	1297	1348	5000
SpinButton	mount	2885	2803	5000
Spinner	mount	391	391	5000
SplitButton	mount	1825	1828	5000
Stack	mount	392	405	5000
StackWithIntrinsicChildren	mount	834	849	5000
StackWithTextChildren	mount	2554	2577	5000
SwatchColorPicker	mount	6047	6106	5000
TagPicker	mount	1439	1425	5000
Text	mount	365	362	5000
TextField	mount	945	951	5000
ThemeProvider	mount	812	827	5000
ThemeProvider	virtual-rerender	577	594	5000
ThemeProvider	virtual-rerender-with-unmount	1253	1272	5000
Toggle	mount	609	599	5000
buttonNative	mount	190	179	5000

fabricteam · 2023-08-17T21:15:52Z

🕵 fluentuiv8 No visual regressions between this PR and main

* master: chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) applying package updates bugfix: ensure interop between assertSlots and old API (microsoft#28957) chore: rename imports from react-tree to react-components (microsoft#28946) applying package updates fix: Autofill queries the inputElement ownerDocument instead of document (microsoft#27312)

* master: (27 commits) feat: Add documentKeyboardEvent to OnVisibleChangeData when Tooltip is hidden via Escape (microsoft#28951) RFC: Component CSS Transitions/Animations on mount/unmount (microsoft#27328) 8.0 Azure Theme: Details list row focus contrast a11y bug fix (microsoft#28966) chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) applying package updates bugfix: ensure interop between assertSlots and old API (microsoft#28957) chore: rename imports from react-tree to react-components (microsoft#28946) applying package updates fix: Autofill queries the inputElement ownerDocument instead of document (microsoft#27312) Accordion : updated styles for accordion header cursor (microsoft#28850) Additional VR tests Charting Library (microsoft#28777) feat(react-motion): create react-motion-preview package scaffolding (microsoft#28947) chore: updates generator to use new slot API (microsoft#28916) chore: bumps version of esbuild-loader to v3.2.0 (microsoft#28878) ...

smhigley added 2 commits March 23, 2023 22:40

fix: Autofill looks up owner document for inputElement

b023f0e

change file

d6ae709

smhigley self-assigned this Mar 23, 2023

msft-fluent-ui-bot added the Component: Autofill label Mar 23, 2023

github-actions Bot added this to the March Project Cycle Q1 2023 milestone Mar 23, 2023

first check WindowContext

18330a1

github-actions Bot modified the milestones: March Project Cycle Q1 2023, August Project Cycle Q4 2023 Aug 17, 2023

smhigley marked this pull request as ready for review August 17, 2023 21:02

smhigley requested review from a team as code owners August 17, 2023 21:02

spmonahan approved these changes Aug 17, 2023

View reviewed changes

sopranopillow approved these changes Aug 18, 2023

View reviewed changes

update api

9d9eb80

spmonahan approved these changes Aug 21, 2023

View reviewed changes

smhigley merged commit 0c71b67 into microsoft:master Aug 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Autofill queries the inputElement ownerDocument instead of document#27312

fix: Autofill queries the inputElement ownerDocument instead of document#27312
smhigley merged 4 commits into
microsoft:masterfrom
smhigley:autofill-document

smhigley commented Mar 23, 2023

Uh oh!

codesandbox-ci Bot commented Mar 23, 2023 •

edited

Loading

Uh oh!

size-auditor Bot commented Mar 23, 2023 •

edited

Loading

Uh oh!

fabricteam commented Mar 23, 2023 •

edited

Loading

Uh oh!

fabricteam commented Mar 23, 2023

Uh oh!

fabricteam commented Mar 23, 2023

Uh oh!

fabricteam commented Mar 23, 2023 •

edited

Loading

Uh oh!

fabricteam commented Aug 17, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

smhigley commented Mar 23, 2023

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

codesandbox-ci Bot commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor Bot commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Mar 23, 2023

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Mar 23, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codesandbox-ci Bot commented Mar 23, 2023 •

edited

Loading

size-auditor Bot commented Mar 23, 2023 •

edited

Loading

fabricteam commented Mar 23, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Mar 23, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Aug 17, 2023 •

edited

Loading