doc: updates doc to make it "codesandbox" compliant#28946
Merged
Conversation
YuanboXue-Amber
approved these changes
Aug 22, 2023
Contributor
|
Let's add an issue to investigate alias import? |
ling1726
reviewed
Aug 22, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 12e58ef:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 599 | 611 | 5000 | |
| Button | mount | 325 | 317 | 5000 | |
| Field | mount | 1105 | 1076 | 5000 | |
| FluentProvider | mount | 661 | 662 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 75 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 77 | 10 | |
| InfoButton | mount | 12 | 16 | 5000 | |
| MakeStyles | mount | 850 | 868 | 50000 | |
| Persona | mount | 1755 | 1692 | 5000 | |
| SpinButton | mount | 1389 | 1377 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0c71b67bb41fdc2de8c3c547e77646a4b2ab36e9 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
force-pushed
the
react-tree/doc--updates-documentation-to-make-it-codesandbox-compliant
branch
from
August 22, 2023 19:25
91bfaf3 to
12e58ef
Compare
ling1726
approved these changes
Aug 22, 2023
bsunderhus
deleted the
react-tree/doc--updates-documentation-to-make-it-codesandbox-compliant
branch
August 23, 2023 07:37
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 23, 2023
* master: chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) applying package updates bugfix: ensure interop between assertSlots and old API (microsoft#28957) chore: rename imports from react-tree to react-components (microsoft#28946) applying package updates fix: Autofill queries the inputElement ownerDocument instead of document (microsoft#27312)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 23, 2023
* master: (27 commits) feat: Add documentKeyboardEvent to OnVisibleChangeData when Tooltip is hidden via Escape (microsoft#28951) RFC: Component CSS Transitions/Animations on mount/unmount (microsoft#27328) 8.0 Azure Theme: Details list row focus contrast a11y bug fix (microsoft#28966) chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) applying package updates bugfix: ensure interop between assertSlots and old API (microsoft#28957) chore: rename imports from react-tree to react-components (microsoft#28946) applying package updates fix: Autofill queries the inputElement ownerDocument instead of document (microsoft#27312) Accordion : updated styles for accordion header cursor (microsoft#28850) Additional VR tests Charting Library (microsoft#28777) feat(react-motion): create react-motion-preview package scaffolding (microsoft#28947) chore: updates generator to use new slot API (microsoft#28916) chore: bumps version of esbuild-loader to v3.2.0 (microsoft#28878) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Seems like something between our storybook code generation and codesandbox seems to break when aliasing an import, we're getting a duplicate identifier error on codesanbox when trying to open the flat tree example.
New Behavior
@fluentui/react-componentsinstead of@fluentui/react-treeRelated Issue(s)