RFC: Component CSS Transitions/Animations on mount/unmount#27328
Merged
marcosmoura merged 24 commits intoAug 23, 2023
Conversation
marcosmoura
changed the title
Collaborator
📊 Bundle size report🤖 This report was generated against afcfb2ebe322e2a8e204ac192e68f48f1164107f |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 17f0406:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 64fec9dade3f8c033b05332207c33479c26bacb4 (build) |
marcosmoura
marked this pull request as ready for review
March 29, 2023 12:48
marcosmoura
changed the title
ling1726
reviewed
Mar 29, 2023
ling1726
reviewed
Mar 29, 2023
ling1726
reviewed
Mar 29, 2023
marcosmoura
marked this pull request as draft
April 4, 2023 13:40
marcosmoura
marked this pull request as ready for review
June 22, 2023 16:59
marcosmoura
changed the title
Contributor
|
@spmonahan will review from @microsoft/cxe-red |
ling1726
reviewed
Jul 3, 2023
ling1726
reviewed
Jul 3, 2023
spmonahan
reviewed
Aug 1, 2023
spmonahan
approved these changes
Aug 11, 2023
tudorpopams
approved these changes
Aug 22, 2023
bsunderhus
approved these changes
Aug 22, 2023
…nt-or-unmount.md Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
…nt-or-unmount.md Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
ling1726
reviewed
Aug 23, 2023
marcosmoura
enabled auto-merge (squash)
August 23, 2023 19:02
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 23, 2023
* master: (27 commits) feat: Add documentKeyboardEvent to OnVisibleChangeData when Tooltip is hidden via Escape (microsoft#28951) RFC: Component CSS Transitions/Animations on mount/unmount (microsoft#27328) 8.0 Azure Theme: Details list row focus contrast a11y bug fix (microsoft#28966) chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) applying package updates bugfix: ensure interop between assertSlots and old API (microsoft#28957) chore: rename imports from react-tree to react-components (microsoft#28946) applying package updates fix: Autofill queries the inputElement ownerDocument instead of document (microsoft#27312) Accordion : updated styles for accordion header cursor (microsoft#28850) Additional VR tests Charting Library (microsoft#28777) feat(react-motion): create react-motion-preview package scaffolding (microsoft#28947) chore: updates generator to use new slot API (microsoft#28916) chore: bumps version of esbuild-loader to v3.2.0 (microsoft#28878) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 25, 2023
…e-motion * feat/use-motion-presence-hook: (25 commits) fix: revert changes to CODEOWNERS fix: remove duplicated code due to a merge conflict fix: upgrade tests fix: set motion as active when animations are disabled fix: remove debug function feat: refactor useMotion to a much more clean/performant logic fix: use correct type for MotionOptions fix: improve typings and documentation feat: Add documentKeyboardEvent to OnVisibleChangeData when Tooltip is hidden via Escape (microsoft#28951) fix: use correct boolean values RFC: Component CSS Transitions/Animations on mount/unmount (microsoft#27328) 8.0 Azure Theme: Details list row focus contrast a11y bug fix (microsoft#28966) fix: remove outdated changefile chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC to add support for CSS Animation and Transition to mount/unmount of elements. Please refer to the RFC document this PR creates.
A full implementation and live examples of this approach can be found here:
Drawer motion