feat: add motion slots to Dialog#31132
Merged
Merged
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
Apr 22, 2024
layershifter
force-pushed
the
feat/add-motion-slot
branch
from
May 13, 2024 14:15
3abe4e1 to
b3da5f9
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 626 | 648 | 5000 | |
| Button | mount | 307 | 309 | 5000 | |
| Field | mount | 1126 | 1111 | 5000 | |
| FluentProvider | mount | 724 | 729 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 92 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 37 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 79 | 10 | |
| MakeStyles | mount | 884 | 861 | 50000 | |
| Persona | mount | 1788 | 1703 | 5000 | |
| SpinButton | mount | 1408 | 1397 | 5000 | |
| SwatchPicker | mount | 1649 | 1657 | 5000 |
layershifter
force-pushed
the
feat/add-motion-slot
branch
3 times, most recently
from
June 17, 2024 13:52
886462a to
bc3ecdc
Compare
Collaborator
|
For feature: #30700 |
layershifter
force-pushed
the
feat/add-motion-slot
branch
3 times, most recently
from
June 26, 2024 02:05
98b0482 to
bbf063d
Compare
layershifter
force-pushed
the
feat/add-motion-slot
branch
from
July 12, 2024 11:24
bbf063d to
7726b5d
Compare
layershifter
force-pushed
the
feat/add-motion-slot
branch
3 times, most recently
from
July 17, 2024 09:57
037067a to
8fe513f
Compare
layershifter
force-pushed
the
feat/add-motion-slot
branch
from
July 17, 2024 10:07
8fe513f to
b9da0f6
Compare
layershifter
marked this pull request as ready for review
July 17, 2024 12:06
bsunderhus
approved these changes
Jul 17, 2024
This was referenced Jul 17, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previous Behavior
Dialog&DialogSurfacehave built-in motion, but it's impossible to customize it.New Behavior
DialoggetssurfaceMotionslotDialogSurfacegetsbackdropMotionslotMotion slots allow to customize or replace built-in motion, see examples in #31984.
Related issues