chore(react-examples): replace storybook deprecated api with static stories#32074
Merged
dmytrokirpa merged 10 commits intoJul 25, 2024
Conversation
dmytrokirpa
added
Fluent UI react (v8)
dmytrokirpa
commented
Jul 23, 2024
dmytrokirpa
commented
Jul 23, 2024
dmytrokirpa
marked this pull request as ready for review
July 23, 2024 11:25
Collaborator
📊 Bundle size report✅ No changes found |
AtishayMsft
approved these changes
Jul 23, 2024
AtishayMsft
left a comment
AtishayMsft
left a comment
Contributor
There was a problem hiding this comment.
Approving from charting package side
dmytrokirpa
added a commit
to dmytrokirpa/fluentui
that referenced
this pull request
Jul 24, 2024
Contributor
Author
|
Could someone from @microsoft/cxe-red take a look on this one? 🙏 It blocks the Storybook v7 migration (#32018) |
spmonahan
approved these changes
Jul 24, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 25, 2024
* master: (77 commits) chore(react-examples): replace storybook deprecated api with static stories (microsoft#32074) [chore]: create base class for accordion item and remove style and layout specific api (microsoft#32102) release: applying package updates - web-components chore(web-components): add test for complex focus management (microsoft#32009) [chore]: create base class for avatar and remove style and layout specific api (microsoft#32083) [chore]: create base class for text input and remove style and layout specific api (microsoft#32080) release: applying package updates - web-components chore:(react-nav-preview) Scaffold AppItem (microsoft#32088) docs(`react-teaching-popover`): Adding subcomponents' API to `TeachingPopover` documentation page (microsoft#32084) feat(web-components): relax setTheme() argument type to allow custom tokens (microsoft#32087) release: applying package updates - react-components [Chore]: Create Spinner base class to abstract out style and layout specific api. (microsoft#32067) [Chore]: Create Progress Bar base class to abstract out style and layout specific api. (microsoft#32066) fix(react-storybook-addon): transform decorator to function in withAriaLive() (microsoft#32011) fix(motion): improve Web Animations API detection in tests (microsoft#32029) chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule (microsoft#32072) release: applying package updates - react v8 release: applying package updates - web-components Chore: Create Divider base class to abstract out style and layout specific api (microsoft#32065) fix(TimePicker): Clear text when date value changes to null (microsoft#31626) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Several deprecated Storybook APIs have been used to dynamically generate and incorporate
react-examplesstories.New Behavior
.storybook/preview.jswith their current counterparts:addDecorator(...)=>export const decorators = [...]addParameters(...)=>export const parameters = [...]configure(module, loadStories)=>stories: getStories()in.storybook/main.js./[ComponentName].[Variant].Example, preserving the existing logic but removing dynamic story generation. For instances where React class components are used, direct re-exporting isn't feasible; hence, they are wrapped and exported as functional components, such asexport const Component = () => <ComponentExample />.No changes have been made to the actual
.doc.tsxor.Example.tsxfiles.Related Issue(s)