Skip to content

chore:(react-nav-preview) Scaffold AppItem#32088

Merged
mltejera merged 6 commits into
microsoft:masterfrom
mltejera:nav/scaffold-app-item
Jul 23, 2024
Merged

chore:(react-nav-preview) Scaffold AppItem#32088
mltejera merged 6 commits into
microsoft:masterfrom
mltejera:nav/scaffold-app-item

Conversation

@mltejera

@mltejera mltejera commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Received spec from Design for the AppItem. This PR:

  • Removed AppNode scaffolding.
  • Added scaffolding for AppItem and AppItemStatic using yarn create-component
  • Commented out exports in their respective stories to keep them from publishing

PFA
image

Ladders to #26649

@fabricteam

fabricteam commented Jul 23, 2024

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

@mltejera
mltejera marked this pull request as ready for review July 23, 2024 22:50
@mltejera
mltejera requested review from a team as code owners July 23, 2024 22:50

@Mitch-At-Work Mitch-At-Work left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid scaffold changes

@mltejera
mltejera force-pushed the nav/scaffold-app-item branch from 7819517 to 142a524 Compare July 23, 2024 23:10
@mltejera
mltejera enabled auto-merge (squash) July 23, 2024 23:11
@mltejera
mltejera merged commit c5f079d into microsoft:master Jul 23, 2024
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jul 25, 2024
* master: (77 commits)
  chore(react-examples): replace storybook deprecated api with static stories (microsoft#32074)
  [chore]: create base class for accordion item and remove style and layout specific api (microsoft#32102)
  release: applying package updates - web-components
  chore(web-components): add test for complex focus management (microsoft#32009)
  [chore]: create base class for avatar and remove style and layout specific api (microsoft#32083)
  [chore]: create base class for text input and remove style and layout specific api (microsoft#32080)
  release: applying package updates - web-components
  chore:(react-nav-preview) Scaffold AppItem (microsoft#32088)
  docs(`react-teaching-popover`): Adding subcomponents' API to `TeachingPopover` documentation page (microsoft#32084)
  feat(web-components): relax setTheme() argument type to allow custom tokens (microsoft#32087)
  release: applying package updates - react-components
  [Chore]: Create Spinner base class to abstract out style and layout specific api. (microsoft#32067)
  [Chore]: Create Progress Bar base class to abstract out style and layout specific api. (microsoft#32066)
  fix(react-storybook-addon): transform decorator to function in withAriaLive() (microsoft#32011)
  fix(motion): improve Web Animations API detection in tests (microsoft#32029)
  chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule (microsoft#32072)
  release: applying package updates - react v8
  release: applying package updates - web-components
  Chore: Create Divider base class to abstract out style and layout specific api (microsoft#32065)
  fix(TimePicker): Clear text when date value changes to null (microsoft#31626)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants